An issue in databrowse's template object_detail.html

[leopku]

1, Steps to reproduce the bug.

i, create a module with a foreignkey and set blank=True and null=True.

ii, create a instance of the module in step 1st, and leave the FK field empty.
iii, install 'databrowse' app and register the model to databrowse.
iv, browse the instance detail info.
An TemplateSyntaxError should be throw out.

2, Issue detail:
TemplateSyntaxError at /databrowse/appname/modelname/objects/objectid/
Caught AttributeError while rendering: 'NoneType' object has no attribute '_get_pk_val'
...
...
...
Template error

In template /opt/Documents/Source/itman/templates/databrowse/object_detail.html, error at line 13
Caught AttributeError while rendering: 'NoneType' object has no attribute '_get_pk_val'

3,How to fix.

Open object_detail.html and go to line 18.
change "{% if field.urls %}" to "{% if field and field.urls %}"

[leopku <leo.ss.pku@…>]

1. Steps to reproduce the bug.
   1. create a module with a foreignkey and set blank=True and null=True.
   2. create a instance of the module in step 1st, and leave the FK field empty.
   3. install 'databrowse' app and register the model to databrowse.
   4. browse the instance detail info. An TemplateSyntaxError? should be throw out.

An TemplateSyntaxError? should be throw out.

2. Issue detail:

TemplateSyntaxError at /db/services/service/objects/4/

Caught AttributeError while rendering: 'NoneType' object has no attribute '_get_pk_val'

...

...

...

Template error

In template /opt/Documents/Source/itman/templates/databrowse/object_detail.html, error at line 13

Caught AttributeError while rendering: 'NoneType' object has no attribute '_get_pk_val'

...

12 <table class="objectinfo">

13 {% for field in object.fields %}

14

15 <tr class="{% cycle 'odd' 'even' %}">

...

3. How to fix.

Open object_detail.html and go to line 18.

change "{% if field.urls %}" to "{% if field and field.urls %}"

[Aymeric Augustin]

I'm sure I've seen this problem before, but it seems it was never reported in Trac.

I'm attaching the patch I wrote to circumvent this bug on projects where I used databrowse.

[anonymous]

aaugustin, thanks a lot for so quick patch.

[anonymous]

looks good, I need it too so please check in :)

[Aymeric Augustin]

My patch doesn't include tests, I'm not sure it can be checked in.

Unfortunately the lack of tests (see #15719) blocks all bugfixes on databrowse.

[Jannis Leidel]

That said, it still needs tests :)

[Preston Holmes]

I'm wontfixing a bunch of databrowse tickets since it is now deprecated. However since this has a patch, and since databrowse doesn't have tests and is unlikely to get them, I'd propose that some simple fixes like this are allowed in without tests to improve databrowse during its twilight.

[Paul McMillan]

In [16883]:

Fixed #16565 -- Fixed a databrowse error on null foreign key, even though databrowse is deprecated. Thanks aaugustin for the patch.