Opened 4 years ago

Closed 4 years ago

#16548 closed Cleanup/optimization (fixed)

ImageField __init__ should use super()

Reported by: anonymous Owned by: pyriku
Component: Database layer (models, ORM) Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

FileField.__init__(...)

should be changed to

super(ImageField.self).__init__(...)

Attachments (1)

image_field_super.diff (666 bytes) - added by pyriku 4 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by mk

  • Component changed from Uncategorized to Database layer (models, ORM)
  • Easy pickings set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by pyriku

  • Has patch set
  • Owner changed from nobody to pyriku
  • Status changed from new to assigned
  • Triage Stage changed from Accepted to Ready for checkin

Attach the patch for this ticket

Changed 4 years ago by pyriku

comment:3 Changed 4 years ago by aaugustin

  • Triage Stage changed from Ready for checkin to Accepted

The patch must be reviewed by someone else before it can be marked as ready for checkin.

See https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/#ready-for-checkin

comment:4 Changed 4 years ago by Aramgutang

  • Triage Stage changed from Accepted to Ready for checkin

Reviewed patch, and ran test suite just to be overcautious.

comment:5 Changed 4 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from assigned to closed

In [16658]:

Fix initialisation of ImageField super classes.

Fixes #16548, with thanks to pyriku.

Note: See TracTickets for help on using tickets.
Back to Top