Opened 5 years ago

Closed 5 years ago

#16548 closed Cleanup/optimization (fixed)

ImageField __init__ should use super()

Reported by: anonymous Owned by: pyriku
Component: Database layer (models, ORM) Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

FileField.__init__(...)

should be changed to

super(ImageField.self).__init__(...)

Attachments (1)

image_field_super.diff (666 bytes) - added by pyriku 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by Matthias Kestenholz

Component: UncategorizedDatabase layer (models, ORM)
Easy pickings: set
Triage Stage: UnreviewedAccepted

comment:2 Changed 5 years ago by pyriku

Has patch: set
Owner: changed from nobody to pyriku
Status: newassigned
Triage Stage: AcceptedReady for checkin

Attach the patch for this ticket

Changed 5 years ago by pyriku

Attachment: image_field_super.diff added

comment:3 Changed 5 years ago by Aymeric Augustin

Triage Stage: Ready for checkinAccepted

The patch must be reviewed by someone else before it can be marked as ready for checkin.

See https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/#ready-for-checkin

comment:4 Changed 5 years ago by Aramgutang

Triage Stage: AcceptedReady for checkin

Reviewed patch, and ran test suite just to be overcautious.

comment:5 Changed 5 years ago by Malcolm Tredinnick

Resolution: fixed
Status: assignedclosed

In [16658]:

Fix initialisation of ImageField super classes.

Fixes #16548, with thanks to pyriku.

Note: See TracTickets for help on using tickets.
Back to Top