Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#16497 closed New feature (fixed)

Adding MXFields to contrib.localflavor

Reported by: Andrés Torres Owned by: nobody
Component: contrib.localflavor Version: 1.3
Severity: Normal Keywords: mexican localflavor
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

We added code, tests, and documentation for the following:

  • forms.MXStateSelect
  • forms.MXZipCodeField
  • forms.MXRFCField
  • forms.MXCURPField
  • models.MXStateField
  • models.MXZipCodeField
  • models.MXRFCField
  • models.MXCURPField

We leave at your disposal our branches in our GitHub repo:

The diff that we're uploading corresponds to the Django 1.3 version.

Authors:

  • Gerardo Orozco <gerardo.orozco.mosqueda@…>
  • Andrés Torres Marroquín <andres.torres.marroquin@…>

Any question you may have, please don't doubt to ask.

Attachments (2)

mx_localflavors-1.3.diff (23.4 KB) - added by Andrés Torres 5 years ago.
Diff for Django 1.3 version
mx_localflavors.diff (26.2 KB) - added by Andrés Torres 5 years ago.
Patch for the lastest trunk - July 28, 2011

Download all attachments as: .zip

Change History (17)

Changed 5 years ago by Andrés Torres

Attachment: mx_localflavors-1.3.diff added

Diff for Django 1.3 version

comment:1 Changed 5 years ago by Aymeric Augustin

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to Aymeric Augustin
Patch needs improvement: unset
Status: newassigned

This was already reported in #9042. However, the patch over there is three years old and yours looks more complete, so I'll close the other ticket.

comment:2 Changed 5 years ago by Aymeric Augustin

Owner: changed from Aymeric Augustin to nobody
Status: assignednew
Triage Stage: UnreviewedAccepted

comment:3 in reply to:  1 Changed 5 years ago by gerardorozco

Replying to aaugustin:

This was already reported in #9042. However, the patch over there is three years old and yours looks more complete, so I'll close the other ticket.

Thank you for the fast reply. What is the next step?

comment:4 Changed 5 years ago by Aymeric Augustin

Someone must review the ticket to ensure it meets our expectations, and it as ready for checkin.

https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/

comment:5 Changed 5 years ago by anonymous

Can you please do a diff against the trunk version?

comment:6 Changed 5 years ago by anonymous

Patch needs improvement: set
Triage Stage: AcceptedUnreviewed

comment:7 Changed 5 years ago by Aymeric Augustin

Triage Stage: UnreviewedAccepted

Indeed, the patch doesn't apply on trunk. You should always upload patches against the latest SVN revision.

But that's not a reason to move the ticket back to unreviewed - see the triage guidelines.

comment:8 Changed 5 years ago by Andrés Torres

We uploaded the patch for the latest trunk, is anything else required?

comment:9 Changed 5 years ago by zodman

its look good for me.

comment:10 Changed 5 years ago by Jannis Leidel

Needs documentation: set

comment:11 in reply to:  10 ; Changed 5 years ago by Andrés Torres

Replying to jezdez:
Can you give us a example of how document this? We thought that all the docstrings would be enough. Thanks by advance.

comment:12 in reply to:  11 ; Changed 5 years ago by Jannis Leidel

Replying to srpoder:

Replying to jezdez:
Can you give us a example of how document this? We thought that all the docstrings would be enough. Thanks by advance.

Sure, have a look at the [source:django/trunk/docs/ref/contrib/localflavor.txt] and its history for an idea of what has been done in the past.

You can see the current docs here: https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

Changed 5 years ago by Andrés Torres

Attachment: mx_localflavors.diff added

Patch for the lastest trunk - July 28, 2011

comment:13 in reply to:  12 Changed 5 years ago by Andrés Torres

Replying to jezdez:

Replying to srpoder:

Replying to jezdez:
Can you give us a example of how document this? We thought that all the docstrings would be enough. Thanks by advance.

Sure, have a look at the [source:django/trunk/docs/ref/contrib/localflavor.txt] and its history for an idea of what has been done in the past.

You can see the current docs here: https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

Thanks a lot jezdez, it is done now, and ready for review.

comment:14 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [16572]:

Fixed #16497 -- Added new form and model fields to the Mexican local flavor. Many thanks to Andrés Torres Marroquín and Gerardo Orozco.

comment:15 Changed 5 years ago by Jacob

milestone: 1.4

Milestone 1.4 deleted

Note: See TracTickets for help on using tickets.
Back to Top