Adding MXFields to contrib.localflavor

[Andrés Torres]

We added code, tests, and documentation for the following:

• forms.MXStateSelect
• forms.MXZipCodeField
• forms.MXRFCField
• forms.MXCURPField
• models.MXStateField
• models.MXZipCodeField
• models.MXRFCField
• models.MXCURPField

We leave at your disposal our branches in our GitHub repo:

• ​https://github.com/Codenga/django/tree/adding-mx-localflavor-1.3 branched from tag 1.3
• ​https://github.com/Codenga/django/tree/adding-mx-localflavor branched from master

The diff that we're uploading corresponds to the Django 1.3 version.

Authors:

• Gerardo Orozco <gerardo.orozco.mosqueda@…>
• Andrés Torres Marroquín <andres.torres.marroquin@…>

Any question you may have, please don't doubt to ask.

[Andrés Torres]

Diff for Django 1.3 version

[Aymeric Augustin]

This was already reported in #9042. However, the patch over there is three years old and yours looks more complete, so I'll close the other ticket.

[gerardorozco]

Replying to aaugustin:

This was already reported in #9042. However, the patch over there is three years old and yours looks more complete, so I'll close the other ticket.

Thank you for the fast reply. What is the next step?

[Aymeric Augustin]

Someone must review the ticket to ensure it meets our expectations, and it as ready for checkin.

​https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/

[anonymous]

Can you please do a diff against the trunk version?

[Aymeric Augustin]

Indeed, the patch doesn't apply on trunk. You should always upload patches against the latest SVN revision.

But that's not a reason to move the ticket back to unreviewed - see the triage guidelines.

[Andrés Torres]

We uploaded the patch for the latest trunk, is anything else required?

[zodman]

its look good for me.

[Andrés Torres]

Replying to jezdez:
Can you give us a example of how document this? We thought that all the docstrings would be enough. Thanks by advance.

[Jannis Leidel]

Replying to srpoder:

Replying to jezdez:
Can you give us a example of how document this? We thought that all the docstrings would be enough. Thanks by advance.

Sure, have a look at the [source:django/trunk/docs/ref/contrib/localflavor.txt] and its history for an idea of what has been done in the past.

You can see the current docs here: ​https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

[Andrés Torres]

Patch for the lastest trunk - July 28, 2011

[Andrés Torres]

Replying to jezdez:

Replying to srpoder:

Replying to jezdez:
Can you give us a example of how document this? We thought that all the docstrings would be enough. Thanks by advance.

Sure, have a look at the [source:django/trunk/docs/ref/contrib/localflavor.txt] and its history for an idea of what has been done in the past.

You can see the current docs here: ​https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

Thanks a lot jezdez, it is done now, and ready for review.

[Jannis Leidel]

In [16572]:

Fixed #16497 -- Added new form and model fields to the Mexican local flavor. Many thanks to Andrés Torres Marroquín and Gerardo Orozco.

[Jacob]

Milestone 1.4 deleted