Forms generated from formsets use ErrorList instead of supplied error_class

[marcin.tustin@…]

Using Django 1.3, forms generated from formsets use ErrorList instead of supplied error_class.

Accordingly, even though a formset is instantiated:

directors_formset = DirectorsFormset(prefix='directors',

data=request.POST,
error_class=SideError)

Forms generated from it use the default ErrorList ul style of error rendering.

The fix is in the first line of FormSet._construct_form, which currently reads:

defaults = {'auto_id': self.auto_id, 'prefix': self.add_prefix(i)}

(https://code.djangoproject.com/browser/django/trunk/django/forms/formsets.py#L114)

This should be changed to:

defaults = {'auto_id': self.auto_id, 'prefix': self.add_prefix(i), 'error_class': self.error_class}

Which passes the error_class down to every form instantiated.

[Simon Charette]

Looks like a bug to me, can someone confirm? If it's accepted it'll need tests.

[Simon Charette]

fix + tests

[Simon Charette]

Added a patch with fix and tests.

[Ludovic Delaveau]

Updated test import

[Ludovic Delaveau]

Updated part of the patch, which could not be applied anymore: changed the context of the additional import required by the test.

[Ludovic Delaveau]

Looks ready for checkin, pull request at ​https://github.com/django/django/pull/423

[Luke Plant <L.Plant.98@…>]

In 7a44dc555a3c9bfd1691ebb346b91f25d2f94c7d:

Fixed #16479 - Forms generated from formsets use ErrorList instead of supplied error_class

Patch with tests from charettes, updated.