Opened 5 years ago

Closed 5 years ago

#16472 closed Cleanup/optimization (fixed)

cleaning django.db.models.query.iterator code

Reported by: fva@… Owned by: nobody
Component: Database layer (models, ORM) Version: 1.3
Severity: Normal Keywords: query iterator
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

removed unused variables pk_val and pk_idx

version 1.4 pre-alpha SVN-16544

Attachments (1)

clean.diff (1.3 KB) - added by fva@… 5 years ago.
trunk diff

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by fva@…

Attachment: clean.diff added

trunk diff

comment:1 Changed 5 years ago by Aymeric Augustin

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedReady for checkin

The patch applies cleanly, a review of the source code indicates that these variables are indeed unused, and the entire test suite passes. Good to go.

comment:2 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [16562]:

Fixed #16472 -- Removed stale code in the query code. Thanks, fva@….

Note: See TracTickets for help on using tickets.
Back to Top