Opened 13 years ago

Closed 13 years ago

#16438 closed Cleanup/optimization (fixed)

class Meta spacing in django.contrib.admin Code Guidelines

Reported by: philipkimmey Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

This is trivial almost to the point of being pedantic, but the class Meta should be separated from the field declarations by a blank line.

I've attached a patch.

Attachments (1)

admin_models.diff​ (765 bytes ) - added by philipkimmey 13 years ago.
Patch to resolve #16438

Download all attachments as: .zip

Change History (6)

comment:1 by Bernhard Essl, 13 years ago

Component: Uncategorized → contrib.admin
Type: Uncategorized → Cleanup/optimization

comment:2 by Stephen Burrows, 13 years ago

Patch needs improvement: set
Triage Stage: Unreviewed → Accepted
Version: 1.3 → SVN

The patch should be from the root of the django source code - i.e. it should be django/contrib/admin/models.py, not contrib/admin/models.py.

by philipkimmey, 13 years ago

Attachment: admin_models.diff​ added

Patch to resolve #16438

comment:3 by philipkimmey, 13 years ago

Sorry about that. I've attached a new patch.

comment:4 by anonymous, 13 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

Patch looks good to me

comment:5 by Jannis Leidel, 13 years ago

Resolution: → fixed
Status: new → closed

In [16601]:

Fixed #16438 -- Corrected whitespace in admin models module. Thanks, philipkimmey.

Note: See TracTickets for help on using tickets.
Back to Top