Code

Opened 3 years ago

Closed 3 years ago

#16438 closed Cleanup/optimization (fixed)

class Meta spacing in django.contrib.admin Code Guidelines

Reported by: philipkimmey Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

This is trivial almost to the point of being pedantic, but the class Meta should be separated from the field declarations by a blank line.

I've attached a patch.

Attachments (1)

admin_models.diff (765 bytes) - added by philipkimmey 3 years ago.
Patch to resolve #16438

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 years ago by BernhardEssl

  • Component changed from Uncategorized to contrib.admin
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Type changed from Uncategorized to Cleanup/optimization

comment:2 Changed 3 years ago by melinath

  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from 1.3 to SVN

The patch should be from the root of the django source code - i.e. it should be django/contrib/admin/models.py, not contrib/admin/models.py.

Changed 3 years ago by philipkimmey

Patch to resolve #16438

comment:3 Changed 3 years ago by philipkimmey

Sorry about that. I've attached a new patch.

comment:4 Changed 3 years ago by anonymous

  • Patch needs improvement unset
  • Triage Stage changed from Accepted to Ready for checkin

Patch looks good to me

comment:5 Changed 3 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

In [16601]:

Fixed #16438 -- Corrected whitespace in admin models module. Thanks, philipkimmey.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.