Opened 5 years ago

Closed 5 years ago

#16438 closed Cleanup/optimization (fixed)

class Meta spacing in django.contrib.admin Code Guidelines

Reported by: philipkimmey Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

This is trivial almost to the point of being pedantic, but the class Meta should be separated from the field declarations by a blank line.

I've attached a patch.

Attachments (1)

admin_models.diff (765 bytes) - added by philipkimmey 5 years ago.
Patch to resolve #16438

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by Bernhard Essl

Component: Uncategorizedcontrib.admin
Type: UncategorizedCleanup/optimization

comment:2 Changed 5 years ago by melinath

Patch needs improvement: set
Triage Stage: UnreviewedAccepted
Version: 1.3SVN

The patch should be from the root of the django source code - i.e. it should be django/contrib/admin/models.py, not contrib/admin/models.py.

Changed 5 years ago by philipkimmey

Attachment: admin_models.diff added

Patch to resolve #16438

comment:3 Changed 5 years ago by philipkimmey

Sorry about that. I've attached a new patch.

comment:4 Changed 5 years ago by anonymous

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

Patch looks good to me

comment:5 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [16601]:

Fixed #16438 -- Corrected whitespace in admin models module. Thanks, philipkimmey.

Note: See TracTickets for help on using tickets.
Back to Top