Opened 4 years ago

Closed 7 months ago

#16432 closed New feature (wontfix)

MultipleObjectMixin should handle pagination prior to get_context_data

Reported by: AndrewIngram Owned by: auvipy
Component: Generic views Version: master
Severity: Normal Keywords:
Cc: AndrewIngram Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


The current implementation of MultipleObjectMixin performs all its pagination operations as part of get_context_data. Some views might require knowledge of pagination earlier in the process, for example a ModelFormSetView I've implemented needs to know about the pagination at the point it instantiates the FormSet, which happens before get_context_data is called.

At the moment we set self.object_list to the result of self.get_queryset(), I am wondering whether self.object_list should actually be the paginated result, and we can store the unpaginated queryset (unevaluated because we won't usually need it) as self.original_object_list (or something nicer) which would also be available in the context data.

I'm concerned that any changes to accomodate this requirement might affect the API of MultipleObjectMixin in a backwards-incompatible way, so I'd like to get feedback from the core devs as to what the right way to tackle this is.

Change History (7)

comment:1 Changed 4 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 4 years ago by AndrewIngram

  • Cc AndrewIngram added

comment:3 Changed 4 years ago by jacob

  • Resolution set to wontfix
  • Status changed from new to closed

I can't see how this could be done in a backwards-compatible way, so I'm going to mark this wontfix. However, if I'm wrong -- entirely possible, I often am! -- please feel free to reopen. A patch would be nice, even an incomplete one -- it's hard to picture this stuff without a bit of code.


comment:4 Changed 7 months ago by auvipy

  • Resolution wontfix deleted
  • Status changed from closed to new
  • Version changed from 1.3 to master

comment:5 Changed 7 months ago by auvipy

  • Owner changed from nobody to auvipy
  • Status changed from new to assigned

comment:6 Changed 7 months ago by bmispelon


Could you explain the reasoning behind you reopening this ticket? In particular, can you address Jacob's concerns of backwards compatibility?


comment:7 Changed 7 months ago by bmispelon

  • Resolution set to wontfix
  • Status changed from assigned to closed

Re-closing per previous comment.

Note: See TracTickets for help on using tickets.
Back to Top