Code

Opened 3 years ago

Closed 3 years ago

#16432 closed New feature (wontfix)

MultipleObjectMixin should handle pagination prior to get_context_data

Reported by: AndrewIngram Owned by: nobody
Component: Generic views Version: 1.3
Severity: Normal Keywords:
Cc: AndrewIngram Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The current implementation of MultipleObjectMixin performs all its pagination operations as part of get_context_data. Some views might require knowledge of pagination earlier in the process, for example a ModelFormSetView I've implemented needs to know about the pagination at the point it instantiates the FormSet, which happens before get_context_data is called.

At the moment we set self.object_list to the result of self.get_queryset(), I am wondering whether self.object_list should actually be the paginated result, and we can store the unpaginated queryset (unevaluated because we won't usually need it) as self.original_object_list (or something nicer) which would also be available in the context data.

I'm concerned that any changes to accomodate this requirement might affect the API of MultipleObjectMixin in a backwards-incompatible way, so I'd like to get feedback from the core devs as to what the right way to tackle this is.

Attachments (0)

Change History (3)

comment:1 Changed 3 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 3 years ago by AndrewIngram

  • Cc AndrewIngram added

comment:3 Changed 3 years ago by jacob

  • Resolution set to wontfix
  • Status changed from new to closed

I can't see how this could be done in a backwards-compatible way, so I'm going to mark this wontfix. However, if I'm wrong -- entirely possible, I often am! -- please feel free to reopen. A patch would be nice, even an incomplete one -- it's hard to picture this stuff without a bit of code.

Thanks!

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.