Code

Opened 3 years ago

Closed 3 years ago

#16381 closed New feature (wontfix)

Specify a folder for the 404.html, 505.html files

Reported by: anonymous Owned by: nobody
Component: HTTP handling Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I think it would be a good idea if we had a setting in the setting.py file so we can change the location of the error pages. I know we could do this with handler404 but i think a setting would be better.

Attachments (0)

Change History (3)

comment:1 Changed 3 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Why do you need this setting? You didn't explain it; "I would have done things differently" isn't sufficient.

I'm not fond of this idea introducing a new setting, unless it's the best solution to a real problem.

I can imagine one use case for such a setting: when one code base is shared by several sites that run with different settings, and each site has his own error pages. But this will only happen in large or complex code bases, where the overhead of redefining handler404 is negligible. You can even define a handler that uses a custom setting to choose the error template. So, it's not a sufficiently good reason to introduce a new standard setting.

comment:2 Changed 3 years ago by anonymous

One can add the intended path to TEMPLATE_DIRS if the default layout is frustrating.

comment:3 Changed 3 years ago by julien

  • Resolution set to wontfix
  • Status changed from new to closed

I agree with aaugustin. The suggestion is appreciated but this is not a common-enough case to justify introducing a new setting, especially since there is already a pretty easy work-around in place.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.