"Conditionally disabling actions" documentation needs updating

[pgullekson@…]

The docs in question are:
​https://docs.djangoproject.com/en/1.3/ref/contrib/admin/actions/#conditionally-enabling-or-disabling-actions

The suggestion is to use del actions['delete_selected'], which worked fine in Django 1.2. However, because of changes made to django.contrib.admin.options.get_actions, in the case that IS_POPUP_VAR == True, this del statement will result in an exception. Need a try/except or something.

[Aymeric Augustin]

Fixed formatting (please use a little bit of wiki syntax and the preview to make your reports readable).

[Julien Phalip]

I think it would be a bit cleaner and read better using the conditional test: if actions.has_key('delete_selected'). What do you think?

[Jannis Leidel]

Please don't use has_key. It's idiomatic to do:

if 'delete_selected' in actions:
    # whatever

[Julien Phalip]

Agreed, that's even better. Thanks for correcting me :p

[Aymeric Augustin]

I'm sure we could write a whole book on the respective merits of

mydict.pop('mykey', None)    # that's unpythonic.

vs.

if 'mykey' in mydict:
    del mydict['mykey']      # we're writing the dict and key names twice!

vs.

try:
    del mydict['mykey']
except KeyError:
    pass                     # four lines for this?

Anyway, here's an updated patch...

Now, back to triaging the unreviewed tickets queue.

[Julien Phalip]

Thanks for the updated patch. IMO, writing the key twice is the lesser evil in this case ;)

[Jannis Leidel]

FTR, I've mentioned that because Alex specifically removed the use of has_key in r14392 to speed up Django a bit. I think it was regarding using Django on PyPy.

[Jannis Leidel]

In [16567]:

Fixed #16377 -- Fixed docs about how to disable the admin actions conditionally to match the current code. Thanks, Aymeric Augustin.