Opened 13 years ago

Last modified 2 years ago

#16260 new New feature

Ability to change dismissRelatedLookupPopup on custom callback function

Reported by: Alex Kamedov Owned by:
Component: contrib.admin Version: dev
Severity: Normal Keywords: admin javascript
Cc: Stephen Burrows Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description

The best solution for some cases for customizing admin is put some links with showRelatedObjectLookupPopup javascript function on admin changelist, but after user choose the object, custom javascript function must be called instead of dismissRelatedLookupPopup javascript function.

Execution of dismissRelatedLookupPopup is hard coded in python code now. The easiest way to implement use case described higher is adding new GET argument "_callback" to changelist view.

Attachments (2)

related_lookup_popup.diff​ (11.7 KB ) - added by Alex Kamedov 13 years ago.
16260-admin-popup-callback.diff​ (12.0 KB ) - added by Julien Phalip 12 years ago.

Download all attachments as: .zip

Change History (9)

by Alex Kamedov, 13 years ago

Attachment: related_lookup_popup.diff​ added

comment:2 by Stephen Burrows, 13 years ago

Cc: Stephen Burrows added
Keywords: javascript added
Triage Stage: Unreviewed → Accepted
Type: Cleanup/optimization → New feature

I would love to see this implemented! I'm not sure if _callback is the best name for the GET parameter, though.

comment:3 by Alex Kamedov, 13 years ago

Version: 1.3 → SVN

comment:4 by Alex Kamedov, 13 years ago

Owner: changed from nobody to Alex Kamedov
Status: new → assigned

by Julien Phalip, 12 years ago

Attachment: 16260-admin-popup-callback.diff​ added

comment:5 by Julien Phalip, 12 years ago

I'm not entirely sold on the implementation but I do want to include this new feature. So I'll chew on it a bit more. In the meantime I've the patch to apply to current code.

comment:6 by Tim Graham, 11 years ago

Easy pickings: unset
Patch needs improvement: set

comment:7 by Mariusz Felisiak, 2 years ago

Owner: Alex Kamedov removed
Status: assigned → new
Note: See TracTickets for help on using tickets.
Back to Top