Code

Opened 3 years ago

Last modified 6 months ago

#16260 assigned New feature

Ability to change dismissRelatedLookupPopup on custom callback function

Reported by: alekam Owned by: alekam
Component: contrib.admin Version: master
Severity: Normal Keywords: admin javascript
Cc: melinath Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description

The best solution for some cases for customizing admin is put some links with showRelatedObjectLookupPopup javascript function on admin changelist, but after user choose the object, custom javascript function must be called instead of dismissRelatedLookupPopup javascript function.

Execution of dismissRelatedLookupPopup is hard coded in python code now. The easiest way to implement use case described higher is adding new GET argument "_callback" to changelist view.

Attachments (2)

related_lookup_popup.diff (11.7 KB) - added by alekam 3 years ago.
16260-admin-popup-callback.diff (12.0 KB) - added by julien 22 months ago.

Download all attachments as: .zip

Change History (8)

Changed 3 years ago by alekam

comment:1 Changed 3 years ago by alekam

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 3 years ago by melinath

  • Cc melinath added
  • Keywords javascript added
  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Cleanup/optimization to New feature

I would love to see this implemented! I'm not sure if _callback is the best name for the GET parameter, though.

comment:3 Changed 3 years ago by alekam

  • Version changed from 1.3 to SVN

comment:4 Changed 3 years ago by alekam

  • Owner changed from nobody to alekam
  • Status changed from new to assigned

Changed 22 months ago by julien

comment:5 Changed 22 months ago by julien

I'm not entirely sold on the implementation but I do want to include this new feature. So I'll chew on it a bit more. In the meantime I've the patch to apply to current code.

comment:6 Changed 6 months ago by timo

  • Easy pickings unset
  • Patch needs improvement set

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as assigned
The owner will be changed from alekam to anonymous. Next status will be 'assigned'
The ticket will be disowned. Next status will be 'new'
as The resolution will be set. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.