Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#16247 closed Cleanup/optimization (fixed)

Remove the wildcard feature of INSTALLED_APPS

Reported by: aaugustin Owned by: nobody
Component: Core (Other) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As discussed on django-developers.

Attachments (1)

16247.diff (2.4 KB) - added by aaugustin 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by aaugustin

  • Owner changed from nobody to aaugustin

Changed 4 years ago by aaugustin

comment:2 Changed 4 years ago by aaugustin

  • Has patch set

comment:3 Changed 4 years ago by melinath

  • Triage Stage changed from Unreviewed to Accepted

comment:4 follow-up: Changed 4 years ago by jezdez

  • Triage Stage changed from Accepted to Design decision needed

As mentioned in the thread on http://groups.google.com/group/django-developers/browse_thread/thread/b35325a078f7a912 this needs a bit of feedback from someone that was involved in adding this feature at the time.

comment:5 in reply to: ↑ 4 ; follow-up: Changed 4 years ago by carljm

Replying to jezdez:

As mentioned in the thread on http://groups.google.com/group/django-developers/browse_thread/thread/b35325a078f7a912 this needs a bit of feedback from someone that was involved in adding this feature at the time.

I don't see that requirement ("needs feedback from someone involved in adding the feature") mentioned in that thread anywhere? I said "if someone pops up" -- I was going to just wait a couple days to see if anyone objects in that thread, and if not, commit this. Personally I don't feel any need to get review from someone involved in adding the feature.

comment:6 in reply to: ↑ 5 Changed 4 years ago by jezdez

Replying to carljm:

Replying to jezdez:

As mentioned in the thread on http://groups.google.com/group/django-developers/browse_thread/thread/b35325a078f7a912 this needs a bit of feedback from someone that was involved in adding this feature at the time.

I don't see that requirement ("needs feedback from someone involved in adding the feature") mentioned in that thread anywhere? I said "if someone pops up" -- I was going to just wait a couple days to see if anyone objects in that thread, and if not, commit this. Personally I don't feel any need to get review from someone involved in adding the feature.

In that case I must have misunderstood your estimation of time when you wrote "if someone pops up". It wrongly indicated to me that you want to genuinely wait for someone that introduced that feature a while ago to be able to explain or even speak against removing of that feature. Without that type of response on the mailing list I find it rather hard to decide for or against the removal of a feature -- whether documented or not. Gladly, it's a minor feature that falls in the category of "nitpicking" so can easily be handled at a later time in a DDN session.

comment:7 Changed 4 years ago by aaugustin

  • Owner changed from aaugustin to nobody

The patch is easy to recreate if it breaks — it just removes a paragraph of code and adds a paragraph of text.

comment:8 Changed 4 years ago by aaugustin

  • Resolution set to fixed
  • Status changed from new to closed

In [17158]:

Fixed #16247 -- Removed wildcard expansion of application names in INSTALLED_APPS.

comment:9 Changed 4 years ago by aaugustin

In [17159]:

Removed tests of the globbing feature that was removed at r17158. Refs #16247.

Note: See TracTickets for help on using tickets.
Back to Top