Opened 13 years ago

Closed 13 years ago

#16210 closed Bug (fixed)

Model validation tests broken in Python 2.5 after [16348]

Reported by: Julien Phalip Owned by: Russell Keith-Magee
Component: Testing framework Version: dev
Severity: Release blocker Keywords: with
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Just need to add "from __future__ import with_statement" at the top of source:django/trunk/tests/modeltests/validation/test_unique.py

Attachments (1)

16210.with_statement.diff​ (337 bytes ) - added by Julien Phalip 13 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Stephen Burrows, 13 years ago

Keywords: with added
Owner: changed from nobody to Stephen Burrows
Status: new → assigned
Triage Stage: Unreviewed → Accepted

by Julien Phalip, 13 years ago

Attachment: 16210.with_statement.diff​ added

comment:2 by Stephen Burrows, 13 years ago

Owner: Stephen Burrows removed
Status: assigned → new

It occurs to me that this may not need a patch since it's so trivial.

Version 0, edited 13 years ago by Stephen Burrows (next)

comment:3 by Stephen Burrows, 13 years ago

Has patch: set
Triage Stage: Accepted → Ready for checkin
Version: 1.3 → SVN

comment:4 by Julien Phalip, 13 years ago

A patch wasn't absolutely necessary here, but it will make the fix that much quicker to be applied ;)

comment:5 by Aymeric Augustin, 13 years ago

I just checked there were no other instances of this problem in the codebase.

comment:6 by Russell Keith-Magee, 13 years ago

Owner: set to Russell Keith-Magee
Resolution: → fixed
Status: new → closed

In [16359]:

Fixed #16210 -- Added some missing future imports to support with statements on 2.5. Thanks to Julien Phalip for the report and patch

Note: See TracTickets for help on using tickets.
Back to Top