Opened 7 years ago

Closed 7 years ago

#16210 closed Bug (fixed)

Model validation tests broken in Python 2.5 after [16348]

Reported by: Julien Phalip Owned by: Russell Keith-Magee
Component: Testing framework Version: master
Severity: Release blocker Keywords: with
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Just need to add "from __future__ import with_statement" at the top of source:django/trunk/tests/modeltests/validation/

Attachments (1)

16210.with_statement.diff (337 bytes) - added by Julien Phalip 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by Stephen Burrows

Keywords: with added
Owner: changed from nobody to Stephen Burrows
Status: newassigned
Triage Stage: UnreviewedAccepted

Changed 7 years ago by Julien Phalip

Attachment: 16210.with_statement.diff added

comment:2 Changed 7 years ago by Stephen Burrows

Owner: Stephen Burrows deleted
Status: assignednew

I was beat to it. Alas! ;-)

Last edited 7 years ago by Stephen Burrows (previous) (diff)

comment:3 Changed 7 years ago by Stephen Burrows

Has patch: set
Triage Stage: AcceptedReady for checkin
Version: 1.3SVN

comment:4 Changed 7 years ago by Julien Phalip

A patch wasn't absolutely necessary here, but it will make the fix that much quicker to be applied ;)

comment:5 Changed 7 years ago by Aymeric Augustin

I just checked there were no other instances of this problem in the codebase.

comment:6 Changed 7 years ago by Russell Keith-Magee

Owner: set to Russell Keith-Magee
Resolution: fixed
Status: newclosed

In [16359]:

Fixed #16210 -- Added some missing future imports to support with statements on 2.5. Thanks to Julien Phalip for the report and patch

Note: See TracTickets for help on using tickets.
Back to Top