Opened 4 years ago

Closed 4 years ago

#16210 closed Bug (fixed)

Model validation tests broken in Python 2.5 after [16348]

Reported by: julien Owned by: russellm
Component: Testing framework Version: master
Severity: Release blocker Keywords: with
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Just need to add "from __future__ import with_statement" at the top of source:django/trunk/tests/modeltests/validation/test_unique.py

Attachments (1)

16210.with_statement.diff (337 bytes) - added by julien 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by melinath

  • Keywords with added
  • Owner changed from nobody to melinath
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted

Changed 4 years ago by julien

comment:2 Changed 4 years ago by melinath

  • Owner melinath deleted
  • Status changed from assigned to new

I was beat to it. Alas! ;-)

Last edited 4 years ago by melinath (previous) (diff)

comment:3 Changed 4 years ago by melinath

  • Has patch set
  • Triage Stage changed from Accepted to Ready for checkin
  • Version changed from 1.3 to SVN

comment:4 Changed 4 years ago by julien

A patch wasn't absolutely necessary here, but it will make the fix that much quicker to be applied ;)

comment:5 Changed 4 years ago by aaugustin

I just checked there were no other instances of this problem in the codebase.

comment:6 Changed 4 years ago by russellm

  • Owner set to russellm
  • Resolution set to fixed
  • Status changed from new to closed

In [16359]:

Fixed #16210 -- Added some missing future imports to support with statements on 2.5. Thanks to Julien Phalip for the report and patch

Note: See TracTickets for help on using tickets.
Back to Top