Code

Opened 3 years ago

Closed 3 years ago

#16204 closed Cleanup/optimization (fixed)

Remove unused functions in admin core.js (getCorrectYear and getISODate).

Reported by: mbraak Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Functions getCorrectYear and getISODate are not used anymore. They should be removed.

Attachments (1)

16204.diff (1.2 KB) - added by melinath 3 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 3 years ago by mbraak

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 3 years ago by aaugustin

  • Has patch unset

There must be a way to download the raw patch from github, but it's not obvious. Could you attach it to this ticket instead?

I know the patch's trivial. We're just enforcing the same procedure for everyone, so that core developers can commit tickets as fast as possible :)

comment:3 Changed 3 years ago by aaugustin

  • Triage Stage changed from Unreviewed to Accepted

I confirm the functions are no longer used.

Changed 3 years ago by melinath

comment:4 Changed 3 years ago by melinath

  • Has patch set

There actually isn't a way (that I could see at least) to download the raw diff from github. So here's one made from applying the patch to my django.

comment:5 Changed 3 years ago by julien

  • Triage Stage changed from Accepted to Ready for checkin

comment:7 Changed 3 years ago by melinath

Hah - great use of <link rel="alternate">. Thanks for the tip.

comment:8 Changed 3 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

In [16642]:

Removed unused admin Javascript functions from source.

Fixed #16204. Thanks, melinath.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.