Opened 5 years ago

Closed 5 years ago

#16200 closed Bug (fixed)

__init__ of TemplateIfParser has return statement

Reported by: Dmitry Trofimov Owned by: nobody
Component: Template system Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description


Attachments (1)

return-removed.patch (585 bytes) - added by Dmitry Trofimov 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by Dmitry Trofimov

Attachment: return-removed.patch added

comment:1 Changed 5 years ago by Dmitry Trofimov

Has patch: set

comment:2 Changed 5 years ago by Aymeric Augustin

Triage Stage: UnreviewedAccepted

This return statement was harmless because super(...) returned None anyvway.

But it's better to remove it, since __init__ is not allowed to return a value <http://docs.python.org/reference/datamodel.html#object.__init__>.

comment:3 Changed 5 years ago by Aymeric Augustin

Triage Stage: AcceptedReady for checkin

The patch is all right, except for the fact that it contains \r\n end-of-lines. It's still possible to apply it as-is.

comment:4 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [16410]:

(The changeset message doesn't reference this ticket)

Note: See TracTickets for help on using tickets.
Back to Top