Incorrect test in contrib.auth silently passes
|Reported by:||Nikolay Zakharov||Owned by:||Nikolay Zakharov|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
There are a test case: [source:django/trunk/django/contrib/auth/tests/permissions.py@16341#L36 auth.TestAuthPermissions]. It checks that the ordering of autogenerated permissions is the same (ticket 14731) by creating permissions and trying to load fixture, then checking that 'loaddata' passed with clean stderr.
The problem is that this fixture ("test_permissions.json") has been checked in with different name ("permissionstestdata.json"). The bigger problem is that "loaddata test_permissions.json" yields "No fixtures found." in stdout, leaving stderr clean. So the test was here and passed without an error since checkin.
Attaching patch that fixes fixture name and the fixture itself (as it contains contenttype for legacy auth.Message model which breaks the test).
Change History (5)
comment:1 Changed 5 years ago by
|Owner:||changed from nobody to Nikolay Zakharov|
|Status:||new → assigned|