Opened 5 years ago

Closed 5 years ago

#16183 closed Bug (fixed)

Incorrect test in contrib.auth silently passes

Reported by: Nikolay Zakharov Owned by: Nikolay Zakharov
Component: contrib.auth Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There are a test case: [source:django/trunk/django/contrib/auth/tests/permissions.py@16341#L36 auth.TestAuthPermissions]. It checks that the ordering of autogenerated permissions is the same (ticket 14731) by creating permissions and trying to load fixture, then checking that 'loaddata' passed with clean stderr.

The problem is that this fixture ("test_permissions.json") has been checked in with different name ("permissionstestdata.json"). The bigger problem is that "loaddata test_permissions.json" yields "No fixtures found." in stdout, leaving stderr clean. So the test was here and passed without an error since checkin.

Attaching patch that fixes fixture name and the fixture itself (as it contains contenttype for legacy auth.Message model which breaks the test).

Attachments (1)

auth_permissions_test_fix_20110609.diff (2.0 KB) - added by Nikolay Zakharov 5 years ago.
Initial patch

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by Nikolay Zakharov

Initial patch

comment:1 Changed 5 years ago by Nikolay Zakharov

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to Nikolay Zakharov
Patch needs improvement: unset
Status: newassigned

comment:2 Changed 5 years ago by Vladimir Moskva

Triage Stage: UnreviewedAccepted

comment:3 Changed 5 years ago by Vladimir Moskva

Triage Stage: AcceptedReady for checkin

comment:4 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: assignedclosed

In [16400]:

Fixed #16183 -- Fixed an ignored auth test. Thanks, desh.

Note: See TracTickets for help on using tickets.
Back to Top