Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#16162 closed Bug (fixed)

DummyCache set_many missing timeout kwarg

Reported by: Simon Litchfield Owned by: Simon Litchfield
Component: Core (Cache system) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

DummyCache set_many missing timeout kwarg

Attachments (2)

dummy-timeout.diff​ (465 bytes ) - added by Simon Litchfield 13 years ago.
dummy-timeout.2.diff​ (1019 bytes ) - added by Aymeric Augustin 13 years ago.

Download all attachments as: .zip

Change History (6)

by Simon Litchfield, 13 years ago

Attachment: dummy-timeout.diff​ added

comment:1 by Aymeric Augustin, 13 years ago

Triage Stage: Unreviewed → Accepted

Indeed, it's inconsistent with the other backends.

by Aymeric Augustin, 13 years ago

Attachment: dummy-timeout.2.diff​ added

comment:2 by Aymeric Augustin, 13 years ago

Updated patch with a regression test.

comment:3 by Preston Holmes, 13 years ago

Triage Stage: Accepted → Ready for checkin
UI/UX: unset

I've applied this patch to current (16726) trunk and tests all pass. Small patch seems RFC

comment:4 by Alex Gaynor, 13 years ago

Resolution: → fixed
Status: new → closed

In [16778]:

Fixed #16162. Added timeout arg to DummyCache.set_many, for compatiblity with other caches. Thanks to aaugustin for the patch.

Note: See TracTickets for help on using tickets.
Back to Top