Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16162 closed Bug (fixed)

DummyCache set_many missing timeout kwarg

Reported by: simon29 Owned by: simon29
Component: Core (Cache system) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no


DummyCache set_many missing timeout kwarg

Attachments (2)

dummy-timeout.diff (465 bytes) - added by simon29 3 years ago.
dummy-timeout.2.diff (1019 bytes) - added by aaugustin 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by simon29

comment:1 Changed 3 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Indeed, it's inconsistent with the other backends.

Changed 3 years ago by aaugustin

comment:2 Changed 3 years ago by aaugustin

Updated patch with a regression test.

comment:3 Changed 3 years ago by ptone

  • Triage Stage changed from Accepted to Ready for checkin
  • UI/UX unset

I've applied this patch to current (16726) trunk and tests all pass. Small patch seems RFC

comment:4 Changed 3 years ago by Alex

  • Resolution set to fixed
  • Status changed from new to closed

In [16778]:

Fixed #16162. Added timeout arg to DummyCache.set_many, for compatiblity with other caches. Thanks to aaugustin for the patch.

Add Comment

Modify Ticket

Change Properties
<Author field>
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.