Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#16162 closed Bug (fixed)

DummyCache set_many missing timeout kwarg

Reported by: Simon Litchfield Owned by: Simon Litchfield
Component: Core (Cache system) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

DummyCache set_many missing timeout kwarg

Attachments (2)

dummy-timeout.diff (465 bytes) - added by Simon Litchfield 6 years ago.
dummy-timeout.2.diff (1019 bytes) - added by Aymeric Augustin 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by Simon Litchfield

Attachment: dummy-timeout.diff added

comment:1 Changed 6 years ago by Aymeric Augustin

Triage Stage: UnreviewedAccepted

Indeed, it's inconsistent with the other backends.

Changed 6 years ago by Aymeric Augustin

Attachment: dummy-timeout.2.diff added

comment:2 Changed 6 years ago by Aymeric Augustin

Updated patch with a regression test.

comment:3 Changed 5 years ago by Preston Holmes

Triage Stage: AcceptedReady for checkin
UI/UX: unset

I've applied this patch to current (16726) trunk and tests all pass. Small patch seems RFC

comment:4 Changed 5 years ago by Alex Gaynor

Resolution: fixed
Status: newclosed

In [16778]:

Fixed #16162. Added timeout arg to DummyCache.set_many, for compatiblity with other caches. Thanks to aaugustin for the patch.

Note: See TracTickets for help on using tickets.
Back to Top