Code

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16145 closed Cleanup/optimization (fixed)

Typo in docs/topics/db/managers.txt

Reported by: lee@… Owned by: leereilly
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX:

Description

Hi,

I submitted a pull request @ https://github.com/django/django/pull/24, but was asked to create a ticket here.

I removed 'object' (shown below in bold) from the following documentation snippet:

The use_for_related_fields attribute must be set on the manager class, object not on an instance of the class. The earlier example shows the correct way to set it, whereas the following will not work::

Do I need to follow the instruction @ https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches, or can the pull request above simply be merged... assuming it is approved of course?

Cheers,

Lee

Attachments (1)

16145.patch (823 bytes) - added by aaugustin 3 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 3 years ago by leereilly

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to leereilly
  • Patch needs improvement unset

Changed 3 years ago by aaugustin

comment:2 Changed 3 years ago by aaugustin

  • Has patch set
  • Triage Stage changed from Unreviewed to Accepted

Regular patch added.

comment:3 Changed 3 years ago by timo

  • Resolution set to fixed
  • Status changed from new to closed

In [16324]:

Fixed #16145 - typo in manager docs; thanks leereilly.

comment:4 Changed 3 years ago by timo

In [16325]:

[1.3.X] Fixed #16145 - typo in manager docs; thanks leereilly.

Backport of r16324 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.