Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16145 closed Cleanup/optimization (fixed)

Typo in docs/topics/db/managers.txt

Reported by: lee@… Owned by: leereilly
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX:

Description

Hi,

I submitted a pull request @ https://github.com/django/django/pull/24, but was asked to create a ticket here.

I removed 'object' (shown below in bold) from the following documentation snippet:

The use_for_related_fields attribute must be set on the manager class, object not on an instance of the class. The earlier example shows the correct way to set it, whereas the following will not work::

Do I need to follow the instruction @ https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches, or can the pull request above simply be merged... assuming it is approved of course?

Cheers,

Lee

Attachments (1)

16145.patch (823 bytes) - added by Aymeric Augustin 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by leereilly

Owner: changed from nobody to leereilly

Changed 6 years ago by Aymeric Augustin

Attachment: 16145.patch added

comment:2 Changed 6 years ago by Aymeric Augustin

Has patch: set
Triage Stage: UnreviewedAccepted

Regular patch added.

comment:3 Changed 6 years ago by Tim Graham

Resolution: fixed
Status: newclosed

In [16324]:

Fixed #16145 - typo in manager docs; thanks leereilly.

comment:4 Changed 6 years ago by Tim Graham

In [16325]:

[1.3.X] Fixed #16145 - typo in manager docs; thanks leereilly.

Backport of r16324 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top