Opened 7 years ago

Last modified 6 years ago

#16142 closed Bug

Coming admin FilterSpec implementation limits querying functionality — at Initial Version

Reported by: subsume@… Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

<jezdez> subsume: please elaborate
<jezdez> or point me to the section where the use case is described if this has been discussed before
<subsume> jezdez here's a test case I whipped up at the time https://github.com/subsume/filter-test/commit/e7c1943c3c4570786ca102dba88d5adf4dc4e1eb

  • pgurumur (~pgurumur@…) has joined #django
  • bradleyayers (~anonymous@…) has joined #django

<jezdez> subsume: why don't you use fm.Company.objects.filter(locationszip_code="90210", locationsopen_days="WEEKEND")?

  • shapr has quit (Quit: hometime, work is over)

<subsume> jezdez I certainly don't mind but that's not the QS that will be generated by the admin filter implementation in place
<jezdez> subsume: not you lost me, what exactly do you want?
<jezdez> *now
<subsume> I wanted a hook to override the broken behavior so I can achieve what you typed. Right now the filters will just loop over and over tacking on a new .filter() each time

  • j00bar (407ddf92@fsf/emeritus/j00bar) has joined #django
  • Finity (6c54d5e9@gateway/web/freenode/ip.108.84.213.233) has joined #django
  • seanbrant has quit (Quit: seanbrant)

<subsume> Because in your case it was part of the same join. In the current implementation its not.

  • fission6 has quit (Quit: Leaving)

<jezdez> subsume: okay, I must have missed that notion from the ticket, please open a ticket and state this exact reason. and no, this shouldn't be fixed with yet another hook, but by making the default filtering more effective in the first
<jezdez> place
<Finity> anyone know how a FileField handle's a blank file
<Finity> apparently it gets set to None, but if I change the file, it apparently doesn't abide by my upload_to rules >_>
<jezdez> subsume: feel free to refer to our conversation here, so it's not lost

The problem is illustrated above and is a continuation of the discussion at #5833.

Change History (0)

Note: See TracTickets for help on using tickets.
Back to Top