Opened 18 years ago

Closed 18 years ago

#1611 closed defect (wontfix)

recent actions list in the auto admin contains broken links to deleted objects.

Reported by: real.human@… Owned by: Adrian Holovaty
Component: contrib.admin Version: 0.91
Severity: minor Keywords: recent actions deleted 404 error
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

if you create an object and then delete it in the auto admin, the recent history pane shows an entry for the creation and deletion of the object. the entry for creation is still linked to the edit object page, which return a 404 now that the object no longer exists. should the link be removed, and a "(deleted") comment, or icon, or strike-through decoration be applied to convey this to the user?

Attachments (1)

0002-Ticket-12232.patch (4.3 KB ) - added by anonymous 11 years ago.
Patch for ticket 12232/1611 against 1.4.2. Adds a new field to LogEntry so you need to migrate (south should take care of it)

Download all attachments as: .zip

Change History (3)

comment:1 by Adrian Holovaty, 18 years ago

priority: normallowest
Severity: normalminor

Good call. The implementation might be tricky, though. At which point do we invalidate those links?

comment:2 by Adrian Holovaty, 18 years ago

Resolution: wontfix
Status: newclosed

Here are a couple of ways this could be solved, neither of which is a great solution:

  • Each time delete() is called, on any model object, Django could delete any related rows in the admin log (which is what produces the "Recent Actions" list). This is bad, because it's unnecessary overhead for an edge case.
  • We could periodically check each entry in the admin log and see whether the object has been deleted. This is bad, because there's no place to hook that in.

With this said, I don't think this is worth fixing.

by anonymous, 11 years ago

Attachment: 0002-Ticket-12232.patch added

Patch for ticket 12232/1611 against 1.4.2. Adds a new field to LogEntry so you need to migrate (south should take care of it)

Note: See TracTickets for help on using tickets.
Back to Top