Code

Opened 8 years ago

Closed 8 years ago

#1611 closed defect (wontfix)

recent actions list in the auto admin contains broken links to deleted objects.

Reported by: real.human@… Owned by: adrian
Component: contrib.admin Version: 0.91
Severity: minor Keywords: recent actions deleted 404 error
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

if you create an object and then delete it in the auto admin, the recent history pane shows an entry for the creation and deletion of the object. the entry for creation is still linked to the edit object page, which return a 404 now that the object no longer exists. should the link be removed, and a "(deleted") comment, or icon, or strike-through decoration be applied to convey this to the user?

Attachments (1)

0002-Ticket-12232.patch (4.3 KB) - added by anonymous 17 months ago.
Patch for ticket 12232/1611 against 1.4.2. Adds a new field to LogEntry so you need to migrate (south should take care of it)

Download all attachments as: .zip

Change History (3)

comment:1 Changed 8 years ago by adrian

  • priority changed from normal to lowest
  • Severity changed from normal to minor

Good call. The implementation might be tricky, though. At which point do we invalidate those links?

comment:2 Changed 8 years ago by adrian

  • Resolution set to wontfix
  • Status changed from new to closed

Here are a couple of ways this could be solved, neither of which is a great solution:

  • Each time delete() is called, on any model object, Django could delete any related rows in the admin log (which is what produces the "Recent Actions" list). This is bad, because it's unnecessary overhead for an edge case.
  • We could periodically check each entry in the admin log and see whether the object has been deleted. This is bad, because there's no place to hook that in.

With this said, I don't think this is worth fixing.

Changed 17 months ago by anonymous

Patch for ticket 12232/1611 against 1.4.2. Adds a new field to LogEntry so you need to migrate (south should take care of it)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.