Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1609 closed defect (invalid)

Typo in db/models/query.py

Reported by: gael.dev@… Owned by: Adrian Holovaty
Component: Database layer (models, ORM) Version: magic-removal
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Typo at line 260 of db/models/query.py :

-    def values(self, *fields):
+    def values(self, fields):

Attachments (1)

query_typo.diff (481 bytes) - added by gael.dev@… 11 years ago.
Simple typo patch

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by gael.dev@…

Attachment: query_typo.diff added

Simple typo patch

comment:1 Changed 11 years ago by Adrian Holovaty

Resolution: invalid
Status: newclosed

That's not a typo. It designates that an arbitrary number of positional arguments are allowed.

comment:2 Changed 11 years ago by gael

hum ok sorry about that.. so the syntax has changed in the magic branch,
xxx.values('id',) instead of xx.get_values(fields=id?) ?

comment:3 Changed 11 years ago by Adrian Holovaty

Yes, that's changed exactly as you've described.

Note: See TracTickets for help on using tickets.
Back to Top