list_filter broken for fields with lenght 2

[Ales Zoulek]

Commit 16144 broke list_filter refering to model fields, when its name is just 2 chars long.

Consider admin options class having

class VenueOptions(admin.ModelAdmin)
    list_filter = ('at', 'when',)

Then in django/contrib/admin/validation.py loops over items in list_filter this way:

                   # item = 'at'

                   #....

76                 try:
77                     # Check for option #2 (tuple)                                                                                                          
78                     field, list_filter_class = item
79                 except (TypeError, ValueError):
80                     # item is option #1
81                     field = item

The check for tuple will fail, since the result would be

field, list_filter_class = 'at'
# results in:
field = 'a'
list_filter_class = 't'

(Tested on svn rev: 16270)

[Julien Phalip]

Fix + tests

[Jannis Leidel]

In [16274]:

Fixed #16080 -- Handle admin list filter items with two characters better. Thanks, Ales Zoulek and Julien Phalip.