Opened 12 years ago
Closed 12 years ago
#16076 closed New feature (fixed)
Updated locale formats for hungarian language
Reported by: | slink | Owned by: | nobody |
---|---|---|---|
Component: | Internationalization | Version: | dev |
Severity: | Normal | Keywords: | locale, formats |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The formats module for the hungarian language was very poor, so I updated it.
Attachments (1)
Change History (7)
comment:1 Changed 12 years ago by
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 Changed 12 years ago by
Needs tests: | set |
---|---|
UI/UX: | unset |
comment:3 Changed 12 years ago by
Easy pickings: | unset |
---|---|
Needs tests: | unset |
Triage Stage: | Accepted → Ready for checkin |
@julien Formats don't require tests; all you'd be testing is that the format string works as expected. It would be like adding tests for translations. We have tests to validate that the format keys work, but we don't need to test that the definitions for each language work as expected.
comment:4 Changed 12 years ago by
Is the first entry to TIME_INPUT_FORMATS
supposed to have a comma?
comment:5 Changed 12 years ago by
@jezdez it was mispelled, thanks for the report. Just uploaded the fixed patch.
Thanks for the report. Could you provide some tests to go along with your fix?