Opened 4 years ago

Closed 4 years ago

#16076 closed New feature (fixed)

Updated locale formats for hungarian language

Reported by: slink Owned by: nobody
Component: Internationalization Version: master
Severity: Normal Keywords: locale, formats
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The formats module for the hungarian language was very poor, so I updated it.

Attachments (1)

formats.patch (1.4 KB) - added by slink 4 years ago.
Patch for hungarian locale formats module

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by julien

  • Needs tests set
  • UI/UX unset

Thanks for the report. Could you provide some tests to go along with your fix?

comment:3 Changed 4 years ago by russellm

  • Easy pickings unset
  • Needs tests unset
  • Triage Stage changed from Accepted to Ready for checkin

@julien Formats don't require tests; all you'd be testing is that the format string works as expected. It would be like adding tests for translations. We have tests to validate that the format keys work, but we don't need to test that the definitions for each language work as expected.

comment:4 Changed 4 years ago by jezdez

Is the first entry to TIME_INPUT_FORMATS supposed to have a comma?

Changed 4 years ago by slink

Patch for hungarian locale formats module

comment:5 Changed 4 years ago by slink

@jezdez it was mispelled, thanks for the report. Just uploaded the fixed patch.

comment:6 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

In [16429]:

Fixed #16076 -- Updated Hungarian l10n formats. Thanks, slink.

Note: See TracTickets for help on using tickets.
Back to Top