#16021 closed Bug (fixed)
Minor documentation fixes for Generic Class Views
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Documentation | Version: | 1.3 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
I noticed some minor styling problems, and one explicit error in the documentation for Generic Class Views.
Attachments (5)
Change History (11)
by , 14 years ago
Attachment: | generic-views-docs.patch added |
---|
comment:1 by , 14 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 14 years ago
Thanks I'll fix up the patch with regard to the model capitalization. The reason why I swapped the order of the Meta and unicode method is due to Django's style guide http://docs.djangoproject.com/en/1.3/internals/contributing/#model-style. There's a list of of the order that the methods should be defined in around the third bullet point in that section.
by , 14 years ago
Attachment: | generic-views-docs-2.patch added |
---|
by , 14 years ago
Attachment: | generic-views-docs-3.patch added |
---|
by , 14 years ago
Attachment: | generic-views-docs-4.patch added |
---|
by , 14 years ago
Attachment: | 16021.generic-views-docs.diff added |
---|
comment:3 by , 14 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Thanks a lot. The patch looks good. I've just capitalized the word "Model" ;-)
comment:6 by , 14 years ago
Whoops, sorry for the confusion. As I said originally, "model" should indeed *not* be capitalized.
Thank you for this. The patch looks mostly fine. Just a couple of points: the word "model" should not be capitalised; also there are no reasons why the
Meta
class should be moved above the__unicode__
method.