Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#15949 closed Bug (fixed)

documentation for view password_reset_done needs changing.

Reported by: cyclops@… Owned by: Horst Gutmann <zerok@…>
Component: Documentation Version: 1.3
Severity: Normal Keywords: dceu2011
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

http://docs.djangoproject.com/en/1.3/topics/auth/#django.contrib.auth.views.password_reset_done

The text reads:

"The page shown after a user has reset their password."

A better wording would be:

"The page shown after a user has been emailed a link to reset their password. This view is called by default, if the view password_reset was not supplied a post_reset_redirect URL.

The exact same change applies to versions 1.2 and development branch.

Attachments (1)

ticket-15949.diff (588 bytes) - added by Horst Gutmann <zerok@…> 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by jonash

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Cleanup/optimization to Bug

(plus password_reset_done is a bad name)

comment:2 Changed 4 years ago by cyclops@…

I agree that password_reset_done is a bad name. However, fixing that would require changing code, whereas my suggestion only involved a documentation change. I wasn't clear on how much or what, should be put into a ticket, but it seemed like a pure text-only change would be simpler.

comment:3 Changed 4 years ago by Horst Gutmann <zerok@…>

  • Owner changed from nobody to Horst Gutmann <zerok@…>
  • UI/UX unset

Changed 4 years ago by Horst Gutmann <zerok@…>

comment:4 Changed 4 years ago by Horst Gutmann <zerok@…>

  • Has patch set

comment:5 Changed 4 years ago by charstring

  • Keywords dceu2011 added
  • Triage Stage changed from Accepted to Ready for checkin

Build the docs without problems and it looks OK.
Describes the behaviour.

comment:6 Changed 4 years ago by timo

  • Resolution set to fixed
  • Status changed from new to closed

In [16378]:

Fixed #15949 - Clarified the docs for password_reset_done view; thanks cyclops for the suggestion; Horst Gutmann for the patch.

comment:7 Changed 4 years ago by timo

In [16379]:

[1.3.X] Fixed #15949 - Clarified the docs for password_reset_done view; thanks cyclops for the suggestion; Horst Gutmann for the patch.

Backport of r16378 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top