Opened 14 years ago
Closed 14 years ago
#15941 closed Cleanup/optimization (fixed)
Admin calendar week start day doc error
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Documentation | Version: | |
Severity: | Normal | Keywords: | calendar week start day |
Cc: | mathieu.agopian@… | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
http://docs.djangoproject.com/en/dev/ref/models/fields/#datefield says:
The JavaScript calendar will always start the week on a Sunday.
This is not true since it can be changed using the FIRST_DAY_OF_WEEK setting and maybe also more l10n I don't know about.
The text is in all the documentations from 1.0 to dev say this, but I don't know which version of Django that introduced FIRST_DAY_OF_WEEK (or other l10n that invalidates that sentence), but maybe it was #1061.
Attachments (1)
Change History (6)
comment:1 by , 14 years ago
Cc: | added |
---|---|
Easy pickings: | set |
Triage Stage: | Unreviewed → Accepted |
Type: | Bug → Cleanup/optimization |
by , 14 years ago
Attachment: | 15941.patch added |
---|
comment:3 by , 14 years ago
Has patch: | set |
---|
comment:4 by , 14 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Well, that was a very quick patch indeed, thanks aaugustin!
Patch looks good, passing this ticket as "ready for checkin"
It seems that FIRST_DAY_OF_WEEK was added in 1.2 (according to http://docs.djangoproject.com/en/1.3/ref/settings/#first-day-of-week), but i can't find any info about that in the release notes of 1.2.
Anyway, i could reproduce the "issue", and indeed this piece of documentation should be updated.