Opened 5 years ago

Closed 5 years ago

#15941 closed Cleanup/optimization (fixed)

Admin calendar week start day doc error

Reported by: r4mses@… Owned by: nobody
Component: Documentation Version:
Severity: Normal Keywords: calendar week start day
Cc: mathieu.agopian@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX:

Description says:

The JavaScript calendar will always start the week on a Sunday.

This is not true since it can be changed using the FIRST_DAY_OF_WEEK setting and maybe also more l10n I don't know about.

The text is in all the documentations from 1.0 to dev say this, but I don't know which version of Django that introduced FIRST_DAY_OF_WEEK (or other l10n that invalidates that sentence), but maybe it was #1061.

Attachments (1)

15941.patch (583 bytes) - added by aaugustin 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by magopian

  • Cc mathieu.agopian@… added
  • Easy pickings set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Bug to Cleanup/optimization

It seems that FIRST_DAY_OF_WEEK was added in 1.2 (according to, but i can't find any info about that in the release notes of 1.2.

Anyway, i could reproduce the "issue", and indeed this piece of documentation should be updated.

Changed 5 years ago by aaugustin

comment:2 Changed 5 years ago by aaugustin

Trivial patch attached.

comment:3 Changed 5 years ago by aaugustin

  • Has patch set

comment:4 Changed 5 years ago by magopian

  • Triage Stage changed from Accepted to Ready for checkin

Well, that was a very quick patch indeed, thanks aaugustin!

Patch looks good, passing this ticket as "ready for checkin"

comment:5 Changed 5 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

In [16174]:

Fixed #15941 -- Fixed DateField docs to no longer state that the admin calendar's week always starts on Sunday (refs FIRST_DAY_OF_WEEK setting). Thanks aaugustin.

Note: See TracTickets for help on using tickets.
Back to Top