Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#15920 closed Cleanup/optimization (fixed)

Feeds support 'COMMENTS_BANNED_USERS_GROUP' but the TT does not.

Reported by: daniellindsley Owned by: nobody
Component: contrib.comments Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX:

Description

Since the comments refactor landed in Django 1.0, the RSS feed (http://code.djangoproject.com/browser/django/trunk/django/contrib/comments/feeds.py#L25) has supported the 'COMMENTS_BANNED_USERS_GROUP' but the template tag (http://code.djangoproject.com/browser/django/trunk/django/contrib/comments/templatetags/comments.py#L74) doesn't. Attached is a patch to make the template
tag support the setting.

Attachments (1)

comments_banned.diff (2.9 KB) - added by daniellindsley 4 years ago.
Patch & tests to add respecting the setting.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by daniellindsley

Patch & tests to add respecting the setting.

comment:1 Changed 4 years ago by aaugustin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Bug to Cleanup/optimization

The following discussion happened in #django-dev when this ticket was filed. It was decided to deprecate the setting rather than fix the templatetag (like the patch does).

28-19:16:49 daniellinds ericholscher: Yeah, those are fine. The question is still remove banned checks from feeds or provide a similar lookup in the TT.
28-19:17:21 ericholsche Seems they should probably go the way of the profanities list
28-19:20:52      jezdez technically we can remove the settings that aren't used in Django, IMO
28-19:21:07      jezdez not sure about COMMENTS_BANNED_USERS_GROUP though
28-19:21:57      jezdez we could remove it and provide a custom LatestCommentFeed subclass in the release notes that shows how to override the items method adding that limitation
28-19:22:27 ericholsche That probably seems best. If someone is depending on that setting, their code is broken anyways
28-19:22:50 ericholsche i guess unless they just use comments feeds
28-19:23:19      jezdez well, it's definitely backwards incompatible, but has a good migration path
28-19:23:30      jezdez s/good/simple/
28-19:23:53 ericholsche it feels a lot like: http://docs.djangoproject.com/en/dev/releases/1.3/#no-more-naughty-words
28-19:24:03      jezdez yup

comment:2 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

In [16124]:

Fixed #15920 -- Removed COMMENTS_BANNED_USERS_GROUP setting in favor of the established comments app customization. Thanks, Daniel Lindsley.

comment:3 Changed 4 years ago by jacob

  • milestone 1.4 deleted

Milestone 1.4 deleted

Note: See TracTickets for help on using tickets.
Back to Top