Storing current language in session/cookie
|Reported by:||msiedlarek||Owned by:||msiedlarek|
|Severity:||Normal||Keywords:||language i18n session cookie|
|Cc:||msiedlarek, raymond.penners@…, vlastimil.zima@…||Triage Stage:||Accepted|
|Has patch:||no||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Description (last modified by lukeplant)
The problem is that even for non-logged users their language is stored in session (if it's supported or in the cookie otherwise). That creates a session for every client, which makes serving static (ofc I mean static, but not media) content through an upstream cache (such as Squid) really inefficient. I suppose selected language is not that secret to protect it by storing in session, and cookie is just ok. For cookie-varying cache it's a huge difference.
There is a setting named LANGUAGE_COOKIE_NAME which never gets used if you use session based cookies. The file cookie is just never saved. But if there were an option to save data in the session and also save the LANGUAGE_COOKIE as a file separately - then it would also persist after logout and solve the issue with languages after the session gets destroyed.
I would propose to have the set_language() view with options to set it as a file based cookie or a session.
It would allow the language file based cookie to have a very long expire date and the session would still be usable for storing secure data.
Change History (4)
comment:1 Changed 5 years ago by lukeplant
- Description modified (diff)
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Accepted