Opened 14 years ago
Closed 14 years ago
#15885 closed New feature (fixed)
Update the docs to explain that auth views now return TemplateResponse
| Reported by: | Preston Timmons | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | 1.3 |
| Severity: | Normal | Keywords: | |
| Cc: | mathieu.agopian@… | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Changeset r16087 modified the auth views to return a TemplateResponse rather than an HttpResponse.
Document the change in the Authentication topic page.
Attachments (3)
Change History (9)
by , 14 years ago
| Attachment: | auth_changes.diff added |
|---|
comment:1 by , 14 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 14 years ago
| Patch needs improvement: | unset |
|---|
Here's my attempt at a "better" documentation, please let me know if that fits what you where expecting prestontimmons.
by , 14 years ago
| Attachment: | auth_views_template_response_doc.diff added |
|---|
comment:3 by , 14 years ago
Thanks FunkyBob on the freenode #django channel for correcting my poor english wording ;)
comment:4 by , 14 years ago
| Cc: | added |
|---|
comment:5 by , 14 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note:
See TracTickets
for help on using tickets.
Hello prestontimmons,
i would personally put this added information, in the documentation, a few lines above (starting line 864, just at the end of the views.login explanation).
What do you think? I feel the way it is now, it's a bit like an afterthought : "oh, btw, the previous view and those coming after now return a TemplateResponse"