Code

Opened 3 years ago

Closed 3 years ago

#15885 closed New feature (fixed)

Update the docs to explain that auth views now return TemplateResponse

Reported by: prestontimmons Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: mathieu.agopian@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX:

Description

Changeset r16087 modified the auth views to return a TemplateResponse rather than an HttpResponse.

Document the change in the Authentication topic page.

Attachments (3)

auth_changes.diff (724 bytes) - added by prestontimmons 3 years ago.
auth_views_template_response_doc.diff (711 bytes) - added by Mathieu Agopian <mathieu.agopian@…> 3 years ago.
auth_views_template_response_doc.2.diff (712 bytes) - added by Mathieu Agopian <mathieu.agopian@…> 3 years ago.
wording

Download all attachments as: .zip

Change History (9)

Changed 3 years ago by prestontimmons

comment:1 Changed 3 years ago by Mathieu Agopian <mathieu.agopian@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

Hello prestontimmons,

i would personally put this added information, in the documentation, a few lines above (starting line 864, just at the end of the views.login explanation).
What do you think? I feel the way it is now, it's a bit like an afterthought : "oh, btw, the previous view and those coming after now return a TemplateResponse"

comment:2 Changed 3 years ago by Mathieu Agopian <mathieu.agopian@…>

  • Patch needs improvement unset

Here's my attempt at a "better" documentation, please let me know if that fits what you where expecting prestontimmons.

Changed 3 years ago by Mathieu Agopian <mathieu.agopian@…>

Changed 3 years ago by Mathieu Agopian <mathieu.agopian@…>

wording

comment:3 Changed 3 years ago by Mathieu Agopian <mathieu.agopian@…>

Thanks FunkyBob on the freenode #django channel for correcting my poor english wording ;)

comment:4 Changed 3 years ago by magopian

  • Cc mathieu.agopian@… added

comment:5 Changed 3 years ago by jezdez

  • Triage Stage changed from Accepted to Ready for checkin

comment:6 Changed 3 years ago by DrMeers

  • Resolution set to fixed
  • Status changed from new to closed

In [16111]:

Fixed #15885 -- Update auth view docs re: TemplateResponse. Thanks prestontimmons.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.