Opened 14 years ago
Closed 13 years ago
#15840 closed Cleanup/optimization (fixed)
[patch] wrap the inner function of the condition decorator
| Reported by: | portante | Owned by: | Zbigniew Siciarz |
|---|---|---|---|
| Component: | Core (Other) | Version: | |
| Severity: | Normal | Keywords: | |
| Cc: | portante | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | yes | UI/UX: | no |
Description
Like all the other inner functions in the django/views/decorators/http.py module, wrap the inner function so that it exposes it's wrapped function's attributes.
Ran the unit tests successfully on my Mac Book Pro (10.6.7, 2 cores, 4 GB), see attached unit test run output.
Attachments (4)
Change History (11)
by , 14 years ago
| Attachment: | 15840.patch.diff added |
|---|
by , 14 years ago
| Attachment: | 15840.unittests.run.log added |
|---|
comment:1 by , 14 years ago
| Component: | Uncategorized → Core (Other) |
|---|---|
| Easy pickings: | set |
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 14 years ago
| Patch needs improvement: | set |
|---|
comment:3 by , 14 years ago
| Patch needs improvement: | unset |
|---|
comment:4 by , 13 years ago
| Patch needs improvement: | set |
|---|---|
| UI/UX: | unset |
Patch doesn't apply clean on trunk.
comment:5 by , 13 years ago
| Owner: | changed from to |
|---|
by , 13 years ago
| Attachment: | 15840.patch.3.diff added |
|---|
Improved the patch so it applies cleanly to current trunk. Only the condition decorator needs testing, as the other two are implemented in terms of it.
Note:
See TracTickets
for help on using tickets.
15840.patch.diff fails to apply cleanly on to trunk