Opened 4 years ago

Closed 4 years ago

#15780 closed Bug (fixed)

Broken link in release notes - csrf upgrade notes

Reported by: Aryeh Leib Taurog <vim@…> Owned by: nobody
Component: Documentation Version: master
Severity: Release blocker Keywords:
Cc: vim@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

When I build docs from svn trunk, I get the following errors:

/tmp/build_django_docs/trunk/docs/releases/1.2.txt:436: WARNING: undefined label: ref-csrf-upgrading-notes
/tmp/build_django_docs/trunk/docs/releases/1.2.txt:863: WARNING: undefined label: ref-csrf-upgrading-notes
/tmp/build_django_docs/trunk/docs/releases/1.2-alpha-1.txt:33: WARNING: undefined label: ref-csrf-upgrading-notes
/tmp/build_django_docs/trunk/docs/releases/1.2-alpha-1.txt:198: WARNING: undefined label: ref-csrf-upgrading-notes

The missing section label ref-csrf-upgrading-notes was removed in changeset:15949 from trunk/docs/ref/contrib/csrf.txt.

The text for the link refers to UPGRADE INSTRUCTIONS.

Change History (4)

comment:1 Changed 4 years ago by julien

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Severity changed from Normal to Release blocker
  • Triage Stage changed from Unreviewed to Accepted

This is a regression so marking as release blocker. The references are in the 1.2-alpha-1 and 1.2 release notes. For as long as any of the versions prior to those will be supported we probably need to revive the "Upgrade notes" by reverting parts of [15949]. Do we still support anything prior to 1.2?

comment:2 Changed 4 years ago by julien

Related issue: #15777

comment:3 Changed 4 years ago by lukeplant

If we kept the upgrading notes we'd have to re-write them, because they refer to temporary measures that don't even exist in current Django, and for someone new to Django we really want things as simple as possible and not cluttered by the history of past mistakes. So I'm going to fix by removing the link in the release notes and adding an note.

comment:4 Changed 4 years ago by lukeplant

  • Resolution set to fixed
  • Status changed from new to closed

In [16023]:

Fixed #15780 - Broken link in old release notes regarding CSRF upgrade

Thanks to Aryeh Leib Taurog for the report.

Note: See TracTickets for help on using tickets.
Back to Top