Opened 5 years ago

Closed 5 years ago

#15763 closed Cleanup/optimization (duplicate)

MultiPartParser's LimitBytes is now redundant.

Reported by: tomchristie Owned by: nobody
Component: HTTP handling Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


It appears that MultiPartParser's use of LimitBytes is now redundant, as byte limiting is enforced by the underlying stream. (Eg WSGIRequest wraps the stream in a LimitedStream wrapper if required.)

I've attached a patch, and a simple sanity check test. This patch relies on #15762, so you'll need to apply both sets of patches.

Attachments (1)

patch_limit_bytes_redundant.diff (4.1 KB) - added by tomchristie 5 years ago.
Patch and test.

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by tomchristie

Patch and test.

comment:1 Changed 5 years ago by tomchristie

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to duplicate
  • Status changed from new to closed

See #15785 for fixing the underlying problem.

Note: See TracTickets for help on using tickets.
Back to Top