RequestFactory Example Doesn't Address Class-Based Views

[Bryan Veloso]

Was attempting to use RequestFactory with class-based generic views. The example as it stands is for functional views only.

[Luke Plant]

To my mind, the example is sufficient, because class-based views are not special, and don't need any special docs. They have no special handling internally to Django. A view is a callable that takes a request and returns a response. The .as_view() method of CBVs simply returns a callable which is such a view. In fact, in the example given, there is nothing to say that my_view is a function, and not any other callable, even one derived from a CBV.

However, I'm aware that lots of people may not get this. But I'm still kind of reluctant to go through every example of a view being used and give CBV based example when there is no need to, since they work identically. Perhaps we need to explain this aspect of CBVs more clearly.

[Bryan Veloso]

Thanks for taking a look Luke. I agree with you 100%. While I was doing the patch, I was like... "It probably would be just as good to throw the fact that you can pass a request like that in the conversion documents (​http://docs.djangoproject.com/en/1.3/topics/generic-views-migration/)." As long as there's some eduction about this (as I would have never figured out that View.as_view()(request) was the correct way to go about it), I'll be happy. :)

[Gabriel Hurley]

Mentioning this in a generic fashion sounds good to me (as per Luke).

[Jacob]

Milestone 1.3 deleted

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[travisby@…]

As a new user, I would like to admit that I would have NEVER figured that out. I've been looking for two days, and finally saw that you're suppose dto use GenericViewClass.as_view()(request)

The worst part is, I still don't understand what it does (but hey, it works). I think it would be very beneficial to add to the documentation.

[Tim Graham]

Add doc method for View.as_view

[Tim Graham <timograham@…>]

In [b139cfc0f7e70e37b9a31e9931c6b03b8a68e918]:

Fixed #15730 - Documented the as_view() method for CBVs.

[raymond@…]

Although more verbose, the format of

generic_view = GenericViewClass.as_view()
generic_view(request)

makes it a bit easier to see what's happening