Opened 14 years ago
Closed 14 years ago
#15717 closed Cleanup/optimization (fixed)
databrowse uses the date-based generic view that is pending deprecation
| Reported by: | Aymeric Augustin | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.databrowse | Version: | 1.3 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In http://code.djangoproject.com/browser/django/trunk/django/contrib/databrowse/plugins/calendars.py:
from django.views.generic import date_based
Since r14254, importing that module raises a PendingDeprecationWarning.
Attachments (1)
Change History (6)
by , 14 years ago
| Attachment: | 15717.diff added |
|---|
comment:1 by , 14 years ago
| Has patch: | set |
|---|
comment:2 by , 14 years ago
| Type: | → Cleanup/optimization |
|---|
comment:3 by , 14 years ago
| Severity: | → Normal |
|---|
comment:4 by , 14 years ago
| Severity: | Normal → Release blocker |
|---|---|
| Triage Stage: | Unreviewed → Ready for checkin |
I think this one is actually a blocker -- because of the way the test suite runs, the generic view is imported as part of the databrowse package, which means running the full test suite causes this deprecation warning to be raised.
Marking RFC because the patch does what it needs to do, and tests for databrowse are a much bigger problem (See #15719).
Note:
See TracTickets
for help on using tickets.
Attached patch ports django.contrib.databrowse to use the new class-based generic views.
I couldn't locate the tests for databrowse :( so I tested the patch by hand. If there are some tests, they should pass as is.