Opened 13 years ago

Closed 13 years ago

#15717 closed Cleanup/optimization (fixed)

databrowse uses the date-based generic view that is pending deprecation

Reported by: Aymeric Augustin Owned by: nobody
Component: contrib.databrowse Version: 1.3
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In http://code.djangoproject.com/browser/django/trunk/django/contrib/databrowse/plugins/calendars.py:

from django.views.generic import date_based

Since r14254, importing that module raises a PendingDeprecationWarning.

Attachments (1)

15717.diff (3.2 KB ) - added by Aymeric Augustin 13 years ago.

Download all attachments as: .zip

Change History (6)

by Aymeric Augustin, 13 years ago

Attachment: 15717.diff added

comment:1 by Aymeric Augustin, 13 years ago

Has patch: set

Attached patch ports django.contrib.databrowse to use the new class-based generic views.

I couldn't locate the tests for databrowse :( so I tested the patch by hand. If there are some tests, they should pass as is.

comment:2 by Luke Plant, 13 years ago

Type: Cleanup/optimization

comment:3 by Luke Plant, 13 years ago

Severity: Normal

comment:4 by Russell Keith-Magee, 13 years ago

Severity: NormalRelease blocker
Triage Stage: UnreviewedReady for checkin

I think this one is actually a blocker -- because of the way the test suite runs, the generic view is imported as part of the databrowse package, which means running the full test suite causes this deprecation warning to be raised.

Marking RFC because the patch does what it needs to do, and tests for databrowse are a much bigger problem (See #15719).

comment:5 by Russell Keith-Magee, 13 years ago

Resolution: fixed
Status: newclosed

In [16002]:

Fixed #15717 -- Updated databrowse to use class-based generic date views. Thanks to aaugustin for the report and draft patch

Note: See TracTickets for help on using tickets.
Back to Top