Code

Opened 3 years ago

Closed 3 years ago

#15717 closed Cleanup/optimization (fixed)

databrowse uses the date-based generic view that is pending deprecation

Reported by: aaugustin Owned by: nobody
Component: contrib.databrowse Version: 1.3
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In http://code.djangoproject.com/browser/django/trunk/django/contrib/databrowse/plugins/calendars.py:

from django.views.generic import date_based

Since r14254, importing that module raises a PendingDeprecationWarning.

Attachments (1)

15717.diff (3.2 KB) - added by aaugustin 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by aaugustin

comment:1 Changed 3 years ago by aaugustin

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Attached patch ports django.contrib.databrowse to use the new class-based generic views.

I couldn't locate the tests for databrowse :( so I tested the patch by hand. If there are some tests, they should pass as is.

comment:2 Changed 3 years ago by lukeplant

  • Type set to Cleanup/optimization

comment:3 Changed 3 years ago by lukeplant

  • Severity set to Normal

comment:4 Changed 3 years ago by russellm

  • Severity changed from Normal to Release blocker
  • Triage Stage changed from Unreviewed to Ready for checkin

I think this one is actually a blocker -- because of the way the test suite runs, the generic view is imported as part of the databrowse package, which means running the full test suite causes this deprecation warning to be raised.

Marking RFC because the patch does what it needs to do, and tests for databrowse are a much bigger problem (See #15719).

comment:5 Changed 3 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [16002]:

Fixed #15717 -- Updated databrowse to use class-based generic date views. Thanks to aaugustin for the report and draft patch

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.