Regression in Forms: KeyError if trying to access nonvalid input from required field
|Reported by:||jonescb||Owned by:||nobody|
|Has patch:||no||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Description (last modified by kmtracey)
I discovered that I'm getting a KeyError when I try to access a blank required field from the clean() method of the Form.
Something like this will trigger the error:
class TestForm(forms.Form) name = forms.CharField() def clean(self): super(forms.Form, self).clean() name = self.cleaned_data['name'] # this is the offending line return self.cleaned_data
If you display that form in a template and the user enters nothing into the field, it causes a KeyError which leads to a 500 error. This same code used to work in Django 1.2, but it doesn't work in 1.3 anymore.
If you set the field to required=False, it does work.
The obvious workaround is to wrap the offending line in a try/except.
The previous functionality was that Django would display an error to the user telling them that the field is required if you configured your templates to display the errors. It still displays that error if you don't try to access keys from self.cleaned_data.
This also happens with EmailField if you enter an invalid email address. I didn't test any other fields though.
Change History (5)
comment:1 Changed 5 years ago by jonescb
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
comment:3 Changed 5 years ago by kmtracey
- Resolution set to needsinfo
- Status changed from new to closed