Inconsistant handling of context_object_name in paginated MultipleObjectMixin

[Dave Hall]

Without pagination, the MultipleObjectMixin uses a context_object_name based on the name of the model being displayed, such as page_list.

However, when you use pagination by specifying paginate_by, the context_object_name becomes the less-than-helpful object_list.

The fix is simple:

​https://github.com/etianen/django/commit/9db221e015185bf422795ef4783b31b154ba3bdd

Basically, the paginator overwrites the queryset with a simple Python list. This patch prevents that.

[Dave Hall]

I'll add in a test to my patch today. Watch this space. :)

[Dave Hall]

Patch with tests

[Julien Phalip]

Thanks, the patch looks good. Could you also update the doc, in particular in ​http://docs.djangoproject.com/en/dev/topics/pagination/ ?

[Julien Phalip]

On a second thought, having two variables (for example "object_list" and "book_list" in your patch) pointing to the same thing doesn't feel very pythonic. Ideally I'd get rid of "object_list", but that would break backwards compatibility. I'd like to hear more viewpoints about this before proceeding further. Adding doc would still be useful though.

Marking as DDN for now as per my concern about the potential "unpythonicity". If someone -- other than etianen, the reporter =) -- thinks this is not a big deal, then please move back to "Accepted".

[Dave Hall]

I'm not quite sure which docs need updating. The page you've linked to doesn't mention generic views at all.

This patch doesn't actually add any functionality. The only thing it does is make the dated generic views work as documented here: ​http://docs.djangoproject.com/en/1.3/ref/class-based-views/#multipleobjectmixin

I think there may be some confusion here. The 'object_list' and 'book_list' duality has existing since the 1.3 release. All I'm doing is making it work as it should! :P

[Julien Phalip]

You're right, I totally got confused. Thanks for correcting me ;)

[Jannis Leidel]

In [16079]:

Fixed #15698 -- Fixed inconsistant handling of context_object_name in paginated MultipleObjectMixin views. Thanks, Dave Hall.

[Jannis Leidel]

In [16080]:

[1.3.X] Fixed #15698 -- Fixed inconsistant handling of context_object_name in paginated MultipleObjectMixin views. Thanks, Dave Hall.

Backport from trunk (r16079).