Save ResolverMatch in HttpRequest

[nischu7]

In order to simplify the implementation of navigation systems within templates, the HttpRequest instance passed around in the request cycle should held a "url_name" property.

Example:
You define a url that looks like this one:

url(r'^$', 'core.views.dashboard', name='dashboard'),

You'll be able to get the name by accessing "request.url_name". This is more efficient than having to re-resolve the URL in the views/middleware classes/template tag implementations etc.

[nischu7]

patch of "django/core/handlers/base.py"

[Adrian Holovaty]

Hmm, we'll have to think hard about whether to add another attribute to HttpRequest.

[nischu7]

I appreciate your sceptical attitude in favor of Django's quality.
On the other hand, storing the "url_name" or even better, the whole ResolverMatch object returned by "RegexURLResolver.resolve" would make things more efficient since you won't need to re-resolve the URL in later phases.

[Julien Phalip]

I'm a bit concerned about this as url_name would only be one part of the picture -- for this feature to be really useful and versatile you'd also need to pass along the url resolving parameters (args and kwargs), but then that would be even more stuff to cram into the HttpRequest object.

This is still an interesting idea though, so I'll mark as DDN in case another clean implementation can be suggested.

[nischu7]

As I already stated in the 2nd comment, I'd just store the ResolverMatch object as it is since it contains everything we need (view callback function, args, kwargs, the url name, as well as the app name). Should I submit another patch?

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Aymeric Augustin]

#16087 is related.

[Aymeric Augustin]

Discussion on django-developers: ​https://groups.google.com/d/topic/django-developers/EJxfOSZOMR4/discussion

[Florian Apolloner]

See ​https://github.com/django/django/pull/399

[Florian Apolloner <florian@…>]

In b946db5241b924c72c1079ce30d9b368e2b82f07:

Fixed #15695 -- Added ResolverMatch to the request object.