TEST_DEPENDENCIES doesn't use TEST_NAME in circular dependency detection.

[slinkp@…]

As far as I can tell, TEST_DEPENDENCIES checks for circular dependencies by looking at the NAME key, ignoring TEST_NAME if it exists.

This means that if you have some aliases that use the same NAME but different TEST_NAMEs, it will bail out reporting a circular dependency even though there isn't one. Example:

DATABASES = {
    'default': {
        'NAME': 'mydb',
         ...
        'TEST_NAME': 'test_mydb',
        'TEST_DEPENDENCIES': ['users'],
    },
    'users': {
        'NAME': 'mydb',
        ...
        'TEST_NAME': 'test_users',
        'TEST_DEPENDENCIES': [],
    },

It's reasonable to ask why you'd have multiple database configs with the same NAME. On OpenBlock we've been doing that as our default setup, because most of our dev rigs and deployments use only one physical database, but when running tests we want to be sure that multi-database setups work.

[slinkp@…]

fwiw, our config hasn't caused any problems to date on Django 1.2.3. I noticed this problem because tests started failing if we tried upgrading to 1.2.4 or 1.2.5, and I traced it to the addition of TEST_DEPENDENCIES.

[anonymous]

test_db_signature in db/backends/[oracle/]creation.py was not using TEST_NAME. Diff attached that gives precedence to TEST_NAME, then NAME

[Jason Peddle]

TEST_NAME, fallback to NAME

[Jason Peddle]

Replying to anonymous:

test_db_signature in db/backends/[oracle/]creation.py was not using TEST_NAME. Diff attached that gives precedence to TEST_NAME, then NAME

Forgot to sign my name.

[Jacob]

Milestone 1.4 deleted

[Tim Graham]

This needs a test.

[Carlton Gibson]

This doesn't reproduce for me on latest main.

These settings:

DATABASES = {
    'default': {
        'ENGINE': 'django.db.backends.sqlite3',
        'NAME': BASE_DIR / 'db.sqlite3',
        'TEST': {
            'NAME': BASE_DIR / 'test_mydb',
            'DEPENDENCIES': ['users'],
        },
    },
    'users': {
        'ENGINE': 'django.db.backends.sqlite3',
        'NAME': BASE_DIR / 'db.sqlite3',
        'TEST': {
            'NAME': BASE_DIR / 'test_users',
            'DEPENDENCIES': [],
        },
    },
}

This model:

from django.db import models

class DefaultModel(models.Model):
    name = models.TextField()

This test:

from django.test import TestCase

from .models import DefaultModel

class TheTests(TestCase):
    databases = '__all__'

    def test_basics(self):
        o = DefaultModel(name="Default")
        o.save()

        o = DefaultModel(name="Users")
        o.save(using="users")

        d = DefaultModel.objects.get()
        u = DefaultModel.objects.using('users').get()

        self.assertEqual(d, u)
        self.assertNotEqual(d.name, u.name)

All runs without error.

I'll upload the project zip in case someone wants to play with it.

...checks for circular dependencies by looking at the NAME key, ignoring TEST_NAME if it exists...

This doesn't look right, at least how the code is now. The check compared aliases, not NAME or TEST['NAME'].

I'll close as worksforme but happy to re-open if someone can provide a reproduce.

[Carlton Gibson]

Test project trying to reproduce circa 2022.