Allow TestRunners to define their own command-line options

[msiedlarek]

The point is to allow custom test runners do define and process their own command-line options, apart from default ones like verbose.

Attached patch is one of possible solutions. Management command just looks for option_list attribute in a test runner and if it's present, adds it to its own option_list. Any comments or better ideas are welcome.

[msiedlarek]

Patch

[Russell Keith-Magee]

Patch looks fine to me. However, it strikes me that this is something that could be tested in some capacity; probably using the infrastructure of the admin_scripts regressiontests.

Also, for future reference: As a matter of process, you shouldn't be triaging your own tickets. If you've submitted a ticket and a patch, just leave it in unreviewed. Someone else makes the call as to whether the ticket is ok, or needs a decision, or is ready for checkin. By marking your own ticket DDN, you have move out out of a list that gets immediate attention (the unreviewed pile) and into a list that gets intermittent attention (the DDN list).

[msiedlarek]

Ok, I'll make some tests for it.

Also thanks for pointing out my mistake - it's my first patch to Django and although I've read contributing docs some mistake just had to be made. ;)

[msiedlarek]

Second version of patch - with documentation

[msiedlarek]

Third version of patch - with documentation and regression tests

[msiedlarek]

Attached third version of patch with documentation and regression tests using admin_scripts infrastructure. My approach to these tests needs an answer - is it ok to cross-import form other test packages?

And other, even more newbie and quite unrelated question - how much contributor has to do to made his way to AUTHORS? :)

[Julien Phalip]

The patch looks good -- I'm going to review it in more detail. You definitely deserve your name on the list of authors, so feel free to resubmit the patch including your name while you can ;)

[msiedlarek]

Ok, attached updated patch. The only last thing that makes me think is whether "versionadded development" in documentation is a correct approach.

[msiedlarek]

Fourth version of patch - merged with r16022 trunk and added AUTHORS entry

[msiedlarek]

Fifth version of patch - compatible with r16102 trunk

[Dmitry Jemerov]

Ticket #16185 is a related issue; it has a patch attached which combines this patch with another new feature: the possibility to specify the test runner class on the command line.

[msiedlarek]

Cool with me I guess

[Russell Keith-Magee]

In [16352]:

Fixed #16185, #15675 -- Added the ability for test runners to define custom options, and to specify a custom test runner at the command line. Thanks to Dmitry Jemerov and Mikołaj Siedlarek for the patch.