Allow limit_choices_to to use a tuple for __in filters

[Christopher Grebs]

If one is to use myfield = models.ForeignKey(MyModel, limit_choices_to={'valuein': ('one', 'two')}) this fails if rendered with django.contrib.admin.widgets:url_params_from_lookup_dict

I attached a Diff that adds a unittest and the fix.

[Christopher Grebs]

sorry for the bad formatting...

If one is to use myfield = models.ForeignKey(MyModel, limit_choices_to={'valuein': ('one', 'two')}) this fails if rendered with django.contrib.admin.widgets:url_params_from_lookup_dict

I attached a Diff that adds a unittest and the fix.

[Christopher Grebs]

Diff with proper testcase and fix for this ticket

[Matthias Kestenholz]

I think this makes lots of sense. The patch fixes the problem and provides a testcase for it. (Applied & ran the testsuite)

[Aymeric Augustin]

Patch is off by one line in a file, but it applies and the whole test suite passes.

Based on the docs, the limit_choices_to argument of ForeignKey must be a dictionary that defines acceptable keyword arguments for filter(). So I checked what filter() would accept in a <field>__in=... argument:

• experimentally, both tuples and lists work.
• the doc says "a given list"; in the context, that means "an iterable of values" rather than "a Python list object". See ​http://docs.djangoproject.com/en/dev/ref/models/querysets/#in

Since this patch is consistent with the docs and with other parts of the framework, I also consider it is RFC.

[Jannis Leidel]

In [16078]:

Fixed #15673 -- Allow limit_choices_to to use a tuple for in filters. Thanks, EnTeQuAk.