#15653 closed Bug (fixed)
minor errors in admin pagination custom tag
Reported by: | Owned by: | ||
---|---|---|---|
Component: | contrib.admin | Version: | 1.1 |
Severity: | Normal | Keywords: | pagination |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | yes | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | yes |
Description
in django.contrib.admin.templates.admin.templatetags.admin_list.py line 48, which currently reads
"page_range.extend(range(0, ON_EACH_SIDE - 1))"
should read
"page_range.extend(range(0, ON_ENDS))"
instead.
Problem is noticeable if you change ON_EACH_SIDE to a value to 2.
Attachments (4)
Change History (16)
by , 14 years ago
Attachment: | 15653.diff added |
---|
by , 14 years ago
Attachment: | on_each_side_2_patched.png added |
---|
by , 14 years ago
Attachment: | on_each_side_2.png added |
---|
Admin pagination when ON_EACH_SIDE = 2 before patch
comment:1 by , 14 years ago
Needs tests: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
Tests need to be written to prove that the end result remains unchanged after this fix :-)
comment:2 by , 14 years ago
Has patch: | set |
---|
comment:3 by , 14 years ago
Type: | → Bug |
---|
comment:4 by , 14 years ago
Severity: | → Normal |
---|
comment:5 by , 13 years ago
UI/UX: | set |
---|
comment:9 by , 11 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:10 by , 11 years ago
Owner: | removed |
---|---|
Status: | assigned → new |
Pull request: https://github.com/django/django/pull/1168
comment:11 by , 11 years ago
Owner: | set to |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Admin pagination when ON_EACH_SIDE = 2 after patch