Opened 4 years ago

Closed 2 years ago

#15641 closed New feature (wontfix)

Allow FileSystemStorage(base_url=None) to disable url access

Reported by: Harm Geerts <hgeerts@…> Owned by: nobody
Component: File uploads/storage Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

changeset:9946 changed the behaviour of passing base_url=None to the FileSystemStorage contructor.
Before the change it would disable url access whereas now it enables access through MEDIA_URL

The attached patch restores the old behaviour.

Attachments (2)

15641.diff (2.7 KB) - added by Harm Geerts <hgeerts@…> 4 years ago.
15641-2.diff (3.7 KB) - added by Harm Geerts <hgeerts@…> 4 years ago.
same patch with additional tests for MEDIA_URL as default

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by Harm Geerts <hgeerts@…>

Changed 4 years ago by Harm Geerts <hgeerts@…>

same patch with additional tests for MEDIA_URL as default

comment:1 Changed 4 years ago by lukeplant

  • Type set to New feature

comment:2 Changed 4 years ago by lukeplant

  • Severity set to Normal

comment:3 Changed 4 years ago by julien

  • Needs documentation set
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:4 Changed 3 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:5 Changed 3 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:6 Changed 2 years ago by apollo13

  • Resolution set to wontfix
  • Status changed from new to closed

Django usually does not and should not serve media files, hence this is imo a non-issue.

Note: See TracTickets for help on using tickets.
Back to Top