Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#15628 closed (fixed)

AdminEmailHandler is useless without request in record

Reported by: Hynek Schlawack Owned by: nobody
Component: Contrib apps Version: dev
Severity: Keywords: logging
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There is an obvious bug inside django/utils/log.py.

If no request is supplied with the LogRecord, the subject of the mail is set flatly to "Error: Unknown URL". This contradicts the docs (​http://docs.djangoproject.com/en/dev/topics/logging/#id2).

The attached patch fixes that by setting the subject the same way as before but omitting the IP if no request has been supplied.

It would be awesome if that could make it into 1.3.

Attachments (1)

log-without-request.diff​ (519 bytes ) - added by Hynek Schlawack 13 years ago.

Download all attachments as: .zip

Change History (4)

by Hynek Schlawack, 13 years ago

Attachment: log-without-request.diff​ added

comment:1 by Russell Keith-Magee, 13 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:2 by Russell Keith-Magee, 13 years ago

Resolution: → fixed
Status: new → closed

In [15869]:

Fixed #15628 -- Made the admin error email more useful when there isn't a request associated with the message. Thanks to hynek for the report and patch.

comment:3 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top