AdminEmailHandler is useless without request in record
|Reported by:||hynek||Owned by:||nobody|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
There is an obvious bug inside django/utils/log.py.
If no request is supplied with the LogRecord, the subject of the mail is set flatly to "Error: Unknown URL". This contradicts the docs (http://docs.djangoproject.com/en/dev/topics/logging/#id2).
The attached patch fixes that by setting the subject the same way as before but omitting the IP if no request has been supplied.
It would be awesome if that could make it into 1.3.
Change History (4)
Changed 5 years ago by hynek
comment:1 Changed 5 years ago by russellm
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Ready for checkin