Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#15597 closed (fixed)

500 error emails in 1.3 include misleading info at bottom

Reported by: KyleMac Owned by: Karen Tracey
Component: Core (Other) Version: 1.3-rc
Severity: Keywords: blocker
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Presumably the emails are generated from the same template as the HTML pages and so they include this snippet at the bottom:

You're seeing this error because you have DEBUG = True in your Django settings file. Change that to False, and Django will display a standard 500 page.

Which is incorrect and mostly irrelevant but also misleading.

Change History (5)

comment:1 Changed 6 years ago by Karen Tracey

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

The proposed change in #15603 kind of "fixes" this by documenting the HTML attachment as exactly what would be seen on the DEBUG page....

comment:2 Changed 6 years ago by Russell Keith-Magee

Component: UncategorizedCore framework
Keywords: blocker added
Triage Stage: UnreviewedAccepted

This is a problem with a new feature, so it needs to be addressed (even if it is just the documentation fix) before we cut 1.3 final.

That said, I'd rather see a proper fix, rather than just documenting it. It shouldn't be hard to use a different template, or make that part of the template optional.

comment:3 Changed 6 years ago by Karen Tracey

Owner: changed from nobody to Karen Tracey

OK, I'll look at getting that end bit suppressed appropriately...

comment:4 Changed 6 years ago by Karen Tracey

Resolution: fixed
Status: newclosed

In [15802]:

Fixed #15597: When formatting the debug page for inclusion in an e-mail, suppress the note about "seeing this" because DEBUG is True.

comment:5 Changed 6 years ago by Karen Tracey

Sorry, forgot to thank KyleMac for report in the commit message...

Note: See TracTickets for help on using tickets.
Back to Top