Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#15588 closed Bug (fixed)

"FileField no longer deletes files" unclear

Reported by: philipn Owned by: nobody
Component: Documentation Version: 1.3-beta
Severity: Normal Keywords:
Cc: dmclain Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX:

Description

The new model <-> FileField behavior documentation is unclear. The way it's currently written leads one to believe that FileFields' delete method doesn't do anything on the disk. But if you call m.file.delete() the file is deleted from disk.

Attached a patch with some suggested wording.

Attachments (1)

filefield_doc.diff (1.6 KB) - added by Philip Neustrom <philipn@…> 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by Philip Neustrom <philipn@…>

Attachment: filefield_doc.diff added

comment:1 Changed 6 years ago by Gabriel Hurley

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 5 years ago by Luke Plant

Type: Bug

comment:3 Changed 5 years ago by Luke Plant

Severity: Normal

comment:4 Changed 5 years ago by dmclain

Easy pickings: unset
Triage Stage: AcceptedReady for checkin

The release notes are already out, as is 1.3, but this language does seem better and it applies cleanly. If updating the release notes is allowed, this patch is worth applying.

comment:5 Changed 5 years ago by dmclain

Cc: dmclain added

comment:6 Changed 5 years ago by Chris Beaven

Resolution: fixed
Status: newclosed

In [16205]:

Fixes #15588 -- 1.3 release documentation for FileField no longer deleting files unclear. Thanks for the patch, Philip Neustrom.

comment:7 Changed 5 years ago by Chris Beaven

In [16206]:

[1.3.X] Fixes #15588 -- 1.3 release documentation for FileField no longer deleting files unclear. Thanks for the patch, Philip Neustrom.

Backport of r16205 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top