Opened 4 years ago

Closed 4 years ago

#15560 closed (fixed)

Redundant definitions of put() in BaseView classes

Reported by: maney@… Owned by: nobody
Component: Generic views Version: master
Severity: Keywords: janitorial
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

ProcessFormView defines the PUT handler as a polymorphic proxy for the POST handler. BaseCreateView and BaseUpdateView contain identical, redundant definitions of put(), which may be removed.

I don't believe any new tests wold be called for; presumably this functionality is already tested.

Attachments (1)

generic-views.patch (1.1 KB) - added by maney 4 years ago.
trivial patch included

Download all attachments as: .zip

Change History (2)

Changed 4 years ago by maney

trivial patch included

comment:1 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

In [15763]:

Fixed #15560 -- Cleaned up some redundant post->put redirections in the class-based generic views. Thanks to maney for the report and patch.

Note: See TracTickets for help on using tickets.
Back to Top