Opened 7 years ago

Closed 7 years ago

#15537 closed (wontfix)

allow the login_url accept a relative path

Reported by: lanyjie Owned by: nobody
Component: contrib.auth Version: 1.3-beta
Severity: Keywords: relative path login_url
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


In the development version, the login_required decorator accepts a parameter named login_url:

def my_view(request): ...

Sometimes, the login_url may depend on the request path (for example, when the path already implies the login name -- the name may even not be known to the user, and the login page would only ask for a password). Allowing a relative path would be great in this case:

def my_view(request): ...

To implement this, simply insert an one-way if-statement into the decorated view function before using login_url:

def login_required(login_url=None, ...):
   def decorated_view(request, *args, **kwds):
      if login_url and not login_url.startswith('/'):
         login_url = request.path + login_url
   return decorated_view

A more general approach is to have login_url accept a callable that takes the request as a parameter and returns an absolute path; however, I don't have a use case for that yet.

Change History (1)

comment:1 Changed 7 years ago by Russell Keith-Magee

Resolution: wontfix
Status: newclosed

I'm not sure I agree that the proposed feature would be a good thing. Authentication shouldnt' be tightly coupled to application design, and the design your proposing would require either a tightly coupled design, or a large number of deployed login views. I'm not sure I want to encourage either of those practices.

If you want to argue for this feature, please start a discussion on django-dev; my suggestion to you would be to try and explain why this sort of design is the right thing. i.e., provide a much better explanation of your use case.

Note: See TracTickets for help on using tickets.
Back to Top