Admin search_field prefixes conflict with db.models.get_field_by_name

[Fabian Büchler]

This issue might be related to #15203 and to the changeset r3601.

In the Django admin, the ModelAdmin.search_fields prefixes (^, =, @) are converted to __istartswith, __iexact and __search respectively in line 258 in django.contrib.admin.views.main:

    or_queries = [models.Q(**{construct_search(str(field_name)): bit}) for field_name in self.search_fields]

A few lines below in line 263 the field names are passed to django.db.models.options.Options.get_field_by_name without stripping the search prefixes first:

    f = self.lookup_opts.get_field_by_name(field_name)[0]

This results in FieldNotFound errors like "Event has no field named '=slug'".

I've attached a working patch.

[Julien Phalip]

Thanks for the report. This is a regression introduced in [15526]. I'll post some tests shortly.

[Julien Phalip]

Your patch looks good. I've added tests for beginning ('^{...') and exact ('=...') matches. Bizarrely I couldn't find any existing tests for these or for full-text matches ('@...') in the existing test suite.}

[Fabian Büchler]

Awesome, thanks for the quick review and tests, Julien!

[Ramiro Morales]

In [15677]:

Fixed #15517 -- Fixed regression in admin search_fields option introduced in r15526. Thanks Fabian Buechler for the report and fix and Julien Phalip for adding tests.

[Jacob]

Milestone 1.3 deleted