MultiValueField should allow subfield requirement

[Jeremy Dunck]

Example:

class PhoneFIeld(MultiValueField):
    def __init__(self, **kwargs):
        super(PhoneField).__init__(self, fields=(
            USPhoneNumberField(required=True),
            forms.CharField(error_messages={'invalid': u'Extension must be numeric'},
                required=False),
        ), required=True)

This would require a change to .clean so that all subfields which were marked required to be filled in, but any non-required subfield would not be required.

Currently, subfield required's are forced to False, and a required at the MultiValueField level means all subfields are required.

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Tai Lee]

I have opened a PR with backwards compatible fix, tests and docs.

​https://github.com/django/django/pull/1048

[Tai Lee]

This also refs #13342 which was closed as wontfix by russellm who accepted this ticket. Presumably this ticket now includes sufficient detail.

[Tim Graham]

PR needs to be rebased to master.

[Tai Lee]

Rebased to master.

[Tim Graham <timograham@…>]

In 12806758347dfd63a3cd1bfc0d925c09fdbd9cff:

Fixed #15511 -- Allow optional fields on MultiValueField` subclasses.

The MultiValueField class gets a new require_all_fields argument that
defaults to True. If set to False, individual fields can be made
optional, and a new incomplete validation error will be raised if any
required fields have empty values.

The incomplete error message can be defined on a MultiValueField
subclass or on each individual field. Skip duplicate errors.

[Nathan Osman]

Just a quick clarification: will this fix make it into the final Django 1.6 release?

[Tim Graham]

No, if you look at the commit you'll see it's been added to the release notes for 1.7.

[Nathan Osman]

After a significant amount of effort, I have succeeded in backporting this fix to Django 1.5.2. Unfortunately, it wasn't possible to backport this fix (#15511) without also backporting #17051. So, here is a patch that combines the fix for both bugs:

​https://gist.github.com/nathan-osman/6347178

I ran the test suite after applying the patch and it seemed to pass without any failures.