Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1551 closed defect (fixed)

Base handler error handling gets confused when the request is bad

Reported by: ned@… Owned by: Adrian Holovaty
Component: Core (Other) Version: 0.91
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


I don't know exactly what circumstances cause this, but the exception handling in can lose track of the important exception to display in the error email. If an exception is thrown from repr(request) at about line 114, then it is that exception which is displayed rather than the original one that invoked the exception handling in the first place.

The solution is to get a copy of the first exception before beginning the handling, so it can be explicitly passed to _get_traceback.

Attachments (1)

patch.txt (2.1 KB) - added by ned@… 13 years ago.
The patch!

Download all attachments as: .zip

Change History (2)

Changed 13 years ago by ned@…

Attachment: patch.txt added

The patch!

comment:1 Changed 13 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [2667]) Fixed #1551 -- Improved base handler to not lose track of important exception in case of exceptions within repr(). Thanks, Ned

Note: See TracTickets for help on using tickets.
Back to Top